third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp - Issue 1962563002: Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp

Issue 1962563002: Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bounds check in ImageDecoder Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.cpp » ('j') | third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp

index 3c51d4d721e9ce215e416a24110b7697c9c91a37..b0356fc0438d2b3b59cde4d3cad94fc0bdd4602e 100644

--- a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp

@@ -86,7 +86,10 @@ void testByteByByteDecode(DecoderCreator createDecoder, const char* file, size_t

if (!decoder->isSizeAvailable())

continue;

+ bool frameIsFullyReceived = decoder->frameIsFullyReceivedAtIndex(frameCount - 1);

ImageFrame* frame = decoder->frameBufferAtIndex(frameCount - 1);

+ if (decoder->filenameExtension() != "webp" || frameIsFullyReceived)

+ EXPECT_EQ(frameIsFullyReceived, decoder->frameIsCompleteAtIndex(frameCount - 1) || decoder->failed());

if (frame && frame->getStatus() == ImageFrame::FrameComplete && framesDecoded < frameCount)

++framesDecoded;

}