third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp - Issue 1962563002: Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

Issue 1962563002: Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert hasSeenAlpha approach in webp & png. bytebybyte unit tests. fixes. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h ('k') | third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp b/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

index fae908a78e567ec303b4b967a767735cffe0861c..dcc7c3ac66909cbcea542138c771747a4de2e617 100644

--- a/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

@@ -166,14 +166,11 @@ int WEBPImageDecoder::repetitionCount() const

return failed() ? cAnimationLoopOnce : m_repetitionCount;

}

-bool WEBPImageDecoder::frameIsCompleteAtIndex(size_t index) const

+bool WEBPImageDecoder::frameIsFullyReceivedAtIndex(size_t index) const

{

- if (!m_demux || m_demuxState <= WEBP_DEMUX_PARSING_HEADER)

- return false;

if (!(m_formatFlags & ANIMATION_FLAG))

- return ImageDecoder::frameIsCompleteAtIndex(index);

- bool frameIsLoadedAtIndex = index < m_frameBufferCache.size();

- return frameIsLoadedAtIndex;

+ return ImageDecoder::frameIsFullyReceivedAtIndex(index) || frameIsCompleteAtIndex(index);

+ return index < m_frameBufferCache.size() || failed();

}

float WEBPImageDecoder::frameDurationAtIndex(size_t index) const