Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp

Issue 1962563002: Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert hasSeenAlpha approach in webp & png. bytebybyte unit tests. fixes. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
diff --git a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
index 3c51d4d721e9ce215e416a24110b7697c9c91a37..b0356fc0438d2b3b59cde4d3cad94fc0bdd4602e 100644
--- a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
+++ b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp
@@ -86,7 +86,10 @@ void testByteByByteDecode(DecoderCreator createDecoder, const char* file, size_t
if (!decoder->isSizeAvailable())
continue;
+ bool frameIsFullyReceived = decoder->frameIsFullyReceivedAtIndex(frameCount - 1);
ImageFrame* frame = decoder->frameBufferAtIndex(frameCount - 1);
+ if (decoder->filenameExtension() != "webp" || frameIsFullyReceived)
aleksandar.stojiljkovic 2016/05/22 15:41:53 The check is conservative - when frameIsFullyRecei
scroggo_chromium 2016/05/23 16:40:42 I'm still not convinced that that is the case. See
aleksandar.stojiljkovic 2016/05/24 11:08:24 Looks like the fix would go to libwebp. I'll check
scroggo_chromium 2016/05/24 13:55:14 Please add a comment explaining why you need to sp
aleksandar.stojiljkovic 2016/05/24 19:24:34 Done.
+ EXPECT_EQ(frameIsFullyReceived, decoder->frameIsCompleteAtIndex(frameCount - 1) || decoder->failed());
if (frame && frame->getStatus() == ImageFrame::FrameComplete && framesDecoded < frameCount)
++framesDecoded;
}

Powered by Google App Engine
This is Rietveld 408576698