Fix ImageDecoder::frameIsCompleteAtIndex - fully received instead of decoded.

third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h

 /*
  * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
  * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 135 matching lines @@
         if (!m_sizeAvailable)
             decodeSize();
         return isDecodedSizeAvailable();
     }
 
     bool isDecodedSizeAvailable() const
     {
         return !m_failed && m_sizeAvailable;
     }
 
+    // Whether the requested frame is fully decoded.
+    inline bool frameIsCompleteAtIndex(size_t frameIndex) const

[scroggo_chromium, 2016/05/09 21:54:33]

Should there be tests for this new method?

Also, I think it's currently only called by subclasses (sorry if I missed one!)
- can we mark it as protected? (If I am mistaken, I'm fine to leave it public.)

[aleksandar.stojiljkovic, 2016/05/10 21:59:31]

It is public because it is called from PNGImageReader::decode.
About tests - it is called on multiple places that are already tested in decoder
tests I didn't see it necessary to test this method. Don't want to use
MockImageDecoder for it, need to think to which test to add it.

+    {
+        return (frameIndex < m_frameBufferCache.size()) && (m_frameBufferCache[frameIndex].getStatus() == ImageFrame::FrameComplete);
+    }
+
     virtual IntSize size() const { return m_size; }
 
     // Decoders which downsample images should override this method to
     // return the actual decoded size.
     virtual IntSize decodedSize() const { return size(); }
 
     // Image decoders that support YUV decoding must override this to
     // provide the size of each component.
     virtual IntSize decodedYUVSize(int component) const
     {
@@ skipping 39 matching lines @@
     virtual int repetitionCount() const { return cAnimationNone; }
 
     // Decodes as much of the requested frame as possible, and returns an
     // ImageDecoder-owned pointer.
     ImageFrame* frameBufferAtIndex(size_t);
 
     // Whether the requested frame has alpha.
     virtual bool frameHasAlphaAtIndex(size_t) const;
 
     // Whether or not the frame is fully received.
-    virtual bool frameIsCompleteAtIndex(size_t) const;
+    virtual bool frameIsFullyReceivedAtIndex(size_t) const;
 
     // Duration for displaying a frame in seconds. This method is only used by
     // animated images.
     virtual float frameDurationAtIndex(size_t) const { return 0; }
 
     // Number of bytes in the decoded frame. Returns 0 if the decoder doesn't
     // have this frame cached (either because it hasn't been decoded, or because
     // it has been cleared).
     size_t frameBytesAtIndex(size_t) const;
 
@@ skipping 113 matching lines @@
     bool m_failed;
 
 #if USE(QCMSLIB)
     OwnPtr<qcms_transform> m_sourceToOutputDeviceColorTransform;
 #endif
 };
 
 } // namespace blink
 
 #endif