Upon clearing, release PersistentNode of cross-thread-persistent also.

Upon clearing, release PersistentNode of cross-thread-persistent also.

Persistent<>s will only allocate an associated PersistentNode when the
heap reference is non-null. And, dually, free the PersistentNode
when the reference is cleared out and set to null.

Extend that freeing of a PersistentNode upon clearing to also apply to
CrossThreadPersistent<>s, making the behavior and lifetimes of
PersistentNodes consistent across both variants of persistent references.

R=haraken
BUG=483380
NOTRY=true

Committed: https://crrev.com/f8abd7cb1432b8df3e44e038079d1a2aedf993d9
Cr-Commit-Position: refs/heads/master@{#392287}

[sof, 2016-05-08 15:05:45]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-05-08 15:05:46]

please take a look.

Been thinking about CrossThreadPersistent<>s off&on lately, and the clearing
done of CTPs on thread detach. I think it is worth having such a mechanism, but
we should be consistent about freeing PersistentNode<>s when assigning null to a
persistent.

[haraken, 2016-05-09 01:03:04]

LGTM

[sof, 2016-05-09 05:08:20]

Description was changed from

==========
Upon clearing, release PersistentNode of cross-thread-persistent also.

Persistent<>s will only allocate an associated PersistentNode when the
heap reference is non-null. And, dually, freeing the PersistentNode
when the reference is cleared out and set to null.

Extend that freeing of a PersistentNode upon clearing to also apply to
CrossThreadPersistent<>s, making the behavior and lifetimes of
PersistentNodes consistent across both variants of Persistent<> references.

R=
BUG=483380
==========

to

==========
Upon clearing, release PersistentNode of cross-thread-persistent also.

Persistent<>s will only allocate an associated PersistentNode when the
heap reference is non-null. And, dually, freeing the PersistentNode
when the reference is cleared out and set to null.

Extend that freeing of a PersistentNode upon clearing to also apply to
CrossThreadPersistent<>s, making the behavior and lifetimes of
PersistentNodes consistent across both variants of Persistent<> references.

R=haraken
BUG=483380
==========

[sof, 2016-05-09 05:08:49]

Description was changed from

==========
Upon clearing, release PersistentNode of cross-thread-persistent also.

Persistent<>s will only allocate an associated PersistentNode when the
heap reference is non-null. And, dually, freeing the PersistentNode
when the reference is cleared out and set to null.

Extend that freeing of a PersistentNode upon clearing to also apply to
CrossThreadPersistent<>s, making the behavior and lifetimes of
PersistentNodes consistent across both variants of Persistent<> references.

R=haraken
BUG=483380
==========

to

==========
Upon clearing, release PersistentNode of cross-thread-persistent also.

Persistent<>s will only allocate an associated PersistentNode when the
heap reference is non-null. And, dually, free the PersistentNode
when the reference is cleared out and set to null.

Extend that freeing of a PersistentNode upon clearing to also apply to
CrossThreadPersistent<>s, making the behavior and lifetimes of
PersistentNodes consistent across both variants of Persistent<> references.

R=haraken
BUG=483380
==========

[sof, 2016-05-09 05:09:20]

Description was changed from

==========
Upon clearing, release PersistentNode of cross-thread-persistent also.

Persistent<>s will only allocate an associated PersistentNode when the
heap reference is non-null. And, dually, free the PersistentNode
when the reference is cleared out and set to null.

Extend that freeing of a PersistentNode upon clearing to also apply to
CrossThreadPersistent<>s, making the behavior and lifetimes of
PersistentNodes consistent across both variants of Persistent<> references.

R=haraken
BUG=483380
==========

to

==========
Upon clearing, release PersistentNode of cross-thread-persistent also.

Persistent<>s will only allocate an associated PersistentNode when the
heap reference is non-null. And, dually, free the PersistentNode
when the reference is cleared out and set to null.

Extend that freeing of a PersistentNode upon clearing to also apply to
CrossThreadPersistent<>s, making the behavior and lifetimes of
PersistentNodes consistent across both variants of persistent references.

R=haraken
BUG=483380
==========

[sof, 2016-05-09 05:09:25]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-05-09 05:09:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1962513002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1962513002/80001

[commit-bot: I haz the power, 2016-05-09 06:09:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 06:09:22]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sof, 2016-05-09 06:15:52]

Description was changed from

==========
Upon clearing, release PersistentNode of cross-thread-persistent also.

Persistent<>s will only allocate an associated PersistentNode when the
heap reference is non-null. And, dually, free the PersistentNode
when the reference is cleared out and set to null.

Extend that freeing of a PersistentNode upon clearing to also apply to
CrossThreadPersistent<>s, making the behavior and lifetimes of
PersistentNodes consistent across both variants of persistent references.

R=haraken
BUG=483380
==========

to

==========
Upon clearing, release PersistentNode of cross-thread-persistent also.

Persistent<>s will only allocate an associated PersistentNode when the
heap reference is non-null. And, dually, free the PersistentNode
when the reference is cleared out and set to null.

Extend that freeing of a PersistentNode upon clearing to also apply to
CrossThreadPersistent<>s, making the behavior and lifetimes of
PersistentNodes consistent across both variants of persistent references.

R=haraken
BUG=483380
NOTRY=true
==========

[sof, 2016-05-09 06:20:14]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-05-09 06:20:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1962513002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1962513002/80001

[commit-bot: I haz the power, 2016-05-09 06:23:28]

Description was changed from

==========
Upon clearing, release PersistentNode of cross-thread-persistent also.

Persistent<>s will only allocate an associated PersistentNode when the
heap reference is non-null. And, dually, free the PersistentNode
when the reference is cleared out and set to null.

Extend that freeing of a PersistentNode upon clearing to also apply to
CrossThreadPersistent<>s, making the behavior and lifetimes of
PersistentNodes consistent across both variants of persistent references.

R=haraken
BUG=483380
NOTRY=true
==========

to

==========
Upon clearing, release PersistentNode of cross-thread-persistent also.

Persistent<>s will only allocate an associated PersistentNode when the
heap reference is non-null. And, dually, free the PersistentNode
when the reference is cleared out and set to null.

Extend that freeing of a PersistentNode upon clearing to also apply to
CrossThreadPersistent<>s, making the behavior and lifetimes of
PersistentNodes consistent across both variants of persistent references.

R=haraken
BUG=483380
NOTRY=true
==========

[commit-bot: I haz the power, 2016-05-09 06:23:29]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-09 06:24:27]

Description was changed from

==========
Upon clearing, release PersistentNode of cross-thread-persistent also.

Persistent<>s will only allocate an associated PersistentNode when the
heap reference is non-null. And, dually, free the PersistentNode
when the reference is cleared out and set to null.

Extend that freeing of a PersistentNode upon clearing to also apply to
CrossThreadPersistent<>s, making the behavior and lifetimes of
PersistentNodes consistent across both variants of persistent references.

R=haraken
BUG=483380
NOTRY=true
==========

to

==========
Upon clearing, release PersistentNode of cross-thread-persistent also.

Persistent<>s will only allocate an associated PersistentNode when the
heap reference is non-null. And, dually, free the PersistentNode
when the reference is cleared out and set to null.

Extend that freeing of a PersistentNode upon clearing to also apply to
CrossThreadPersistent<>s, making the behavior and lifetimes of
PersistentNodes consistent across both variants of persistent references.

R=haraken
BUG=483380
NOTRY=true

Committed: https://crrev.com/f8abd7cb1432b8df3e44e038079d1a2aedf993d9
Cr-Commit-Position: refs/heads/master@{#392287}
==========

[commit-bot: I haz the power, 2016-05-09 06:24:28]

Patchset 5 (id:??) landed as
https://crrev.com/f8abd7cb1432b8df3e44e038079d1a2aedf993d9
Cr-Commit-Position: refs/heads/master@{#392287}

[sof, 2016-05-10 08:30:42]

fyi, spending some time chasing down a flaky crasher which shows up most likely
because of this CL,


https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__db...

I don't understand how the CTP could end up in that state, but if I still don't
before too long, will revert and investigate locally.