Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1962503002: Add mojom module suffix in .mojom files for components/filesystem. (Closed)

Created:
4 years, 7 months ago by leonhsl(Using Gerrit)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, kalyank, qsr+mojo_chromium.org, rjkroege, sadrul, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mojom module suffix in .mojom files for components/filesystem. 'module filesystem;' --> 'module filesystem.mojom;' This way generated bindings will consistently live in a mojom sub-namespace and avoid collision with non-mojom types. This CL is for these .mojom files: components/filesystem/public/interfaces/*.mojom TBR=jochen, sky BUG=588964 Committed: https://crrev.com/997448573a9c20271e2e45db666ee2173ae6f9f3 Cr-Commit-Position: refs/heads/master@{#392538}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+749 lines, -709 lines) Patch
M ash/mus/sysui_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/directory_impl.h View 4 chunks +8 lines, -8 lines 0 comments Download
M components/filesystem/directory_impl.cc View 12 chunks +68 lines, -64 lines 0 comments Download
M components/filesystem/directory_impl_unittest.cc View 1 5 chunks +80 lines, -78 lines 0 comments Download
M components/filesystem/file_impl.h View 4 chunks +11 lines, -11 lines 0 comments Download
M components/filesystem/file_impl.cc View 17 chunks +48 lines, -47 lines 0 comments Download
M components/filesystem/file_impl_unittest.cc View 1 17 chunks +263 lines, -242 lines 0 comments Download
M components/filesystem/file_system_app.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/filesystem/file_system_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/filesystem/file_system_impl.h View 1 chunk +6 lines, -7 lines 0 comments Download
M components/filesystem/file_system_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M components/filesystem/files_test_base.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/filesystem/files_test_base.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h View 2 chunks +10 lines, -9 lines 0 comments Download
M components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc View 5 chunks +13 lines, -14 lines 0 comments Download
M components/filesystem/public/cpp/prefs/pref_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/interfaces/directory.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/interfaces/file.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/interfaces/file_system.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/interfaces/types.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/shared_temp_dir.h View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/test_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/util.h View 1 chunk +8 lines, -8 lines 0 comments Download
M components/filesystem/util.cc View 3 chunks +52 lines, -50 lines 0 comments Download
M components/leveldb/env_mojo.cc View 10 chunks +14 lines, -13 lines 0 comments Download
M components/leveldb/leveldb_mojo_proxy.h View 4 chunks +28 lines, -26 lines 0 comments Download
M components/leveldb/leveldb_mojo_proxy.cc View 13 chunks +71 lines, -64 lines 0 comments Download
M components/leveldb/leveldb_service_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_service_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_service_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M components/leveldb/public/interfaces/leveldb.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M components/leveldb/test_manifest.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/mus/mus_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M services/catalog/catalog.h View 2 chunks +3 lines, -3 lines 0 comments Download
M services/catalog/catalog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/catalog/manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M services/catalog/public/cpp/resource_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M services/catalog/public/cpp/resource_loader.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M services/shell/shell.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M services/user/public/interfaces/user_service.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M services/user/user_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/user/user_service.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/views/mus/aura_init.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 36 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962503002/1
4 years, 7 months ago (2016-05-08 09:15:12 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/184180)
4 years, 7 months ago (2016-05-08 09:29:05 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962503002/20001
4 years, 7 months ago (2016-05-08 12:02:49 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/184188)
4 years, 7 months ago (2016-05-08 12:41:20 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962503002/40001
4 years, 7 months ago (2016-05-08 13:26:50 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223930)
4 years, 7 months ago (2016-05-08 13:49:23 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962503002/40001
4 years, 7 months ago (2016-05-08 14:53:50 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962503002/60001
4 years, 7 months ago (2016-05-08 15:12:00 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/225235)
4 years, 7 months ago (2016-05-08 16:14:35 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962503002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962503002/80001
4 years, 7 months ago (2016-05-09 02:01:47 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-09 02:54:46 UTC) #22
leonhsl(Using Gerrit)
Would you PTAL? Thanks~ erg: For OWNER review of components/filesystem and services/user rockot@: For OWNER ...
4 years, 7 months ago (2016-05-09 03:05:06 UTC) #24
leonhsl(Using Gerrit)
On 2016/05/09 03:05:06, leonhsl wrote: > Would you PTAL? Thanks~ > > erg: For OWNER ...
4 years, 7 months ago (2016-05-09 03:23:44 UTC) #25
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-09 15:46:08 UTC) #26
Elliot Glaysher
lgtm
4 years, 7 months ago (2016-05-09 17:23:48 UTC) #27
leonhsl(Using Gerrit)
Thanks for kindly review. Let me TBR jochen@ for content/browser/dom_storage/dom_storage_context_wrapper.cc sky@ for ash/mus/sysui_application.cc and ui/views/mus/aura_init.cc ...
4 years, 7 months ago (2016-05-10 02:14:02 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962503002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962503002/80001
4 years, 7 months ago (2016-05-10 02:16:10 UTC) #31
leonhsl(Using Gerrit)
4 years, 7 months ago (2016-05-10 02:17:46 UTC) #33
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-10 03:48:24 UTC) #34
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 03:49:35 UTC) #36
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/997448573a9c20271e2e45db666ee2173ae6f9f3
Cr-Commit-Position: refs/heads/master@{#392538}

Powered by Google App Engine
This is Rietveld 408576698