Revert of GetAccountIdFromProfile() should not return an empty account id if a valid profile is provided.

Revert of GetAccountIdFromProfile() should not return an empty account id if a valid profile is provided. (patchset #7 id:160001 of https://codereview.chromium.org/1880923003/ )

Reason for revert:
Causes leaks: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/12421/steps/unit_tests%20on%20Ubuntu-12.04/logs/BrowserFinderChromeOSTest.FindBrowserOwnedByAnotherProfile

=================================================================
==5853==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0xa4f11b in operator new(unsigned long) (/tmp/runJuOWov/out/Release/unit_tests+0xa4f11b)
    #1 0xf4375a6 in chrome::MultiUserWindowManagerChromeOS::AddUser(content::BrowserContext*) chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:405:7
    #2 0x5654cde in test::BrowserFinderChromeOSTest::CreateMultiUserProfile(AccountId const&) chrome/browser/ui/browser_finder_chromeos_unittest.cc:43:5
    #3 0x237acd9 in BrowserWithTestWindowTest::SetUp() chrome/test/base/browser_with_test_window_test.cc:67:14
    #4 0x56539c2 in test::BrowserFinderChromeOSTest::SetUp() chrome/browser/ui/browser_finder_chromeos_unittest.cc:76:5
    #5 0x73422b6 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
    #6 0x73422b6 in testing::Test::Run() testing/gtest/src/gtest.cc:2470

Original issue's description:
> GetAccountIdFromProfile() should not return an empty account id if a valid profile is provided.
>
> On Chrome OS, we don't end the session immediately if a refresh token is revoked in the session. Thus it's possible that we get an empty account id for a profile from Profile::GetProfileUserName(). We should avoid this scenario on Chrome OS.
>
> BUG=602807, 532535
>
> Committed: https://crrev.com/d2a0bb5307f8d0d09aff9d5d531dd9704fe85841
> Cr-Commit-Position: refs/heads/master@{#392133}

TBR=skuhne@chromium.org,rogerta@chromium.org,xdai@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602807, 532535
Committed: https://crrev.com/8b8411dffb41a7f908aab07401953721c1395b2c
Cr-Commit-Position: refs/heads/master@{#392258}

[Nico, 2016-05-07 14:12:55]

Created Revert of GetAccountIdFromProfile() should not return an empty account
id if a valid profile is provided.

[commit-bot: I haz the power, 2016-05-07 14:13:38]

Description was changed from

==========
Revert of GetAccountIdFromProfile() should not return an empty account id if a
valid profile is provided. (patchset #7 id:160001 of
https://codereview.chromium.org/1880923003/ )

Reason for revert:
Causes leaks:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

=================================================================
==5853==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0xa4f11b in operator new(unsigned long)
(/tmp/runJuOWov/out/Release/unit_tests+0xa4f11b)
    #1 0xf4375a6 in
chrome::MultiUserWindowManagerChromeOS::AddUser(content::BrowserContext*)
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:405:7
    #2 0x5654cde in
test::BrowserFinderChromeOSTest::CreateMultiUserProfile(AccountId const&)
chrome/browser/ui/browser_finder_chromeos_unittest.cc:43:5
    #3 0x237acd9 in BrowserWithTestWindowTest::SetUp()
chrome/test/base/browser_with_test_window_test.cc:67:14
    #4 0x56539c2 in test::BrowserFinderChromeOSTest::SetUp()
chrome/browser/ui/browser_finder_chromeos_unittest.cc:76:5
    #5 0x73422b6 in HandleExceptionsInMethodIfSupported<testing::Test, void>
testing/gtest/src/gtest.cc:2458:12
    #6 0x73422b6 in testing::Test::Run() testing/gtest/src/gtest.cc:2470


Original issue's description:
> GetAccountIdFromProfile() should not return an empty account id if a valid
profile is provided.
> 
> On Chrome OS, we don't end the session immediately if a refresh token is
revoked in the session. Thus it's possible that we get an empty account id for a
profile from Profile::GetProfileUserName(). We should avoid this scenario on
Chrome OS.
> 
> BUG=602807, 532535
> 
> Committed: https://crrev.com/d2a0bb5307f8d0d09aff9d5d531dd9704fe85841
> Cr-Commit-Position: refs/heads/master@{#392133}

TBR=skuhne@chromium.org,rogerta@chromium.org,xdai@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602807, 532535
==========

to

==========
Revert of GetAccountIdFromProfile() should not return an empty account id if a
valid profile is provided. (patchset #7 id:160001 of
https://codereview.chromium.org/1880923003/ )

Reason for revert:
Causes leaks:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

=================================================================
==5853==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0xa4f11b in operator new(unsigned long)
(/tmp/runJuOWov/out/Release/unit_tests+0xa4f11b)
    #1 0xf4375a6 in
chrome::MultiUserWindowManagerChromeOS::AddUser(content::BrowserContext*)
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:405:7
    #2 0x5654cde in
test::BrowserFinderChromeOSTest::CreateMultiUserProfile(AccountId const&)
chrome/browser/ui/browser_finder_chromeos_unittest.cc:43:5
    #3 0x237acd9 in BrowserWithTestWindowTest::SetUp()
chrome/test/base/browser_with_test_window_test.cc:67:14
    #4 0x56539c2 in test::BrowserFinderChromeOSTest::SetUp()
chrome/browser/ui/browser_finder_chromeos_unittest.cc:76:5
    #5 0x73422b6 in HandleExceptionsInMethodIfSupported<testing::Test, void>
testing/gtest/src/gtest.cc:2458:12
    #6 0x73422b6 in testing::Test::Run() testing/gtest/src/gtest.cc:2470


Original issue's description:
> GetAccountIdFromProfile() should not return an empty account id if a valid
profile is provided.
> 
> On Chrome OS, we don't end the session immediately if a refresh token is
revoked in the session. Thus it's possible that we get an empty account id for a
profile from Profile::GetProfileUserName(). We should avoid this scenario on
Chrome OS.
> 
> BUG=602807, 532535
> 
> Committed: https://crrev.com/d2a0bb5307f8d0d09aff9d5d531dd9704fe85841
> Cr-Commit-Position: refs/heads/master@{#392133}

TBR=skuhne@chromium.org,rogerta@chromium.org,xdai@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602807, 532535
==========

[commit-bot: I haz the power, 2016-05-07 14:14:47]

Description was changed from

==========
Revert of GetAccountIdFromProfile() should not return an empty account id if a
valid profile is provided. (patchset #7 id:160001 of
https://codereview.chromium.org/1880923003/ )

Reason for revert:
Causes leaks:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

=================================================================
==5853==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0xa4f11b in operator new(unsigned long)
(/tmp/runJuOWov/out/Release/unit_tests+0xa4f11b)
    #1 0xf4375a6 in
chrome::MultiUserWindowManagerChromeOS::AddUser(content::BrowserContext*)
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:405:7
    #2 0x5654cde in
test::BrowserFinderChromeOSTest::CreateMultiUserProfile(AccountId const&)
chrome/browser/ui/browser_finder_chromeos_unittest.cc:43:5
    #3 0x237acd9 in BrowserWithTestWindowTest::SetUp()
chrome/test/base/browser_with_test_window_test.cc:67:14
    #4 0x56539c2 in test::BrowserFinderChromeOSTest::SetUp()
chrome/browser/ui/browser_finder_chromeos_unittest.cc:76:5
    #5 0x73422b6 in HandleExceptionsInMethodIfSupported<testing::Test, void>
testing/gtest/src/gtest.cc:2458:12
    #6 0x73422b6 in testing::Test::Run() testing/gtest/src/gtest.cc:2470


Original issue's description:
> GetAccountIdFromProfile() should not return an empty account id if a valid
profile is provided.
> 
> On Chrome OS, we don't end the session immediately if a refresh token is
revoked in the session. Thus it's possible that we get an empty account id for a
profile from Profile::GetProfileUserName(). We should avoid this scenario on
Chrome OS.
> 
> BUG=602807, 532535
> 
> Committed: https://crrev.com/d2a0bb5307f8d0d09aff9d5d531dd9704fe85841
> Cr-Commit-Position: refs/heads/master@{#392133}

TBR=skuhne@chromium.org,rogerta@chromium.org,xdai@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602807, 532535
==========

to

==========
Revert of GetAccountIdFromProfile() should not return an empty account id if a
valid profile is provided. (patchset #7 id:160001 of
https://codereview.chromium.org/1880923003/ )

Reason for revert:
Causes leaks:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

=================================================================
==5853==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0xa4f11b in operator new(unsigned long)
(/tmp/runJuOWov/out/Release/unit_tests+0xa4f11b)
    #1 0xf4375a6 in
chrome::MultiUserWindowManagerChromeOS::AddUser(content::BrowserContext*)
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:405:7
    #2 0x5654cde in
test::BrowserFinderChromeOSTest::CreateMultiUserProfile(AccountId const&)
chrome/browser/ui/browser_finder_chromeos_unittest.cc:43:5
    #3 0x237acd9 in BrowserWithTestWindowTest::SetUp()
chrome/test/base/browser_with_test_window_test.cc:67:14
    #4 0x56539c2 in test::BrowserFinderChromeOSTest::SetUp()
chrome/browser/ui/browser_finder_chromeos_unittest.cc:76:5
    #5 0x73422b6 in HandleExceptionsInMethodIfSupported<testing::Test, void>
testing/gtest/src/gtest.cc:2458:12
    #6 0x73422b6 in testing::Test::Run() testing/gtest/src/gtest.cc:2470

Original issue's description:
> GetAccountIdFromProfile() should not return an empty account id if a valid
profile is provided.
>
> On Chrome OS, we don't end the session immediately if a refresh token is
revoked in the session. Thus it's possible that we get an empty account id for a
profile from Profile::GetProfileUserName(). We should avoid this scenario on
Chrome OS.
>
> BUG=602807, 532535
>
> Committed: https://crrev.com/d2a0bb5307f8d0d09aff9d5d531dd9704fe85841
> Cr-Commit-Position: refs/heads/master@{#392133}

TBR=skuhne@chromium.org,rogerta@chromium.org,xdai@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602807, 532535

Committed: https://crrev.com/8b8411dffb41a7f908aab07401953721c1395b2c
Cr-Commit-Position: refs/heads/master@{#392258}
==========