Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196243009: Just some cleanup before I start on the profile name fix. (Closed)

Created:
6 years, 9 months ago by Roger Tawa OOO till Jul 10th
Modified:
6 years, 8 months ago
Reviewers:
noms (inactive)
CC:
chromium-reviews
Visibility:
Public.

Description

Just some cleanup before I start on the profile name fix. Make GAIAInfoUpdateService listen to signin manager and use its api instead of directly accessing the username pref. BUG=351970 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260630 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261309

Patch Set 1 #

Total comments: 6

Patch Set 2 : rebased #

Patch Set 3 : Address review comments #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Patch Set 6 : Fix merge with SM refactor #

Patch Set 7 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -53 lines) Patch
M chrome/browser/profiles/gaia_info_update_service.h View 1 2 3 4 5 2 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service.cc View 1 2 5 chunks +33 lines, -10 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service_factory.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service_unittest.cc View 1 2 7 chunks +53 lines, -37 lines 0 comments Download
M components/signin/core/browser/signin_manager.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Monica, Please take a look. Thanks.
6 years, 9 months ago (2014-03-21 19:33:32 UTC) #1
noms (inactive)
https://codereview.chromium.org/196243009/diff/1/chrome/browser/profiles/gaia_info_update_service.cc File chrome/browser/profiles/gaia_info_update_service.cc (right): https://codereview.chromium.org/196243009/diff/1/chrome/browser/profiles/gaia_info_update_service.cc#newcode184 chrome/browser/profiles/gaia_info_update_service.cc:184: profile_ = NULL; Can you maybe add a comment ...
6 years, 9 months ago (2014-03-24 13:35:24 UTC) #2
Roger Tawa OOO till Jul 10th
Thanks Monica. Please take another look. https://codereview.chromium.org/196243009/diff/1/chrome/browser/profiles/gaia_info_update_service.cc File chrome/browser/profiles/gaia_info_update_service.cc (right): https://codereview.chromium.org/196243009/diff/1/chrome/browser/profiles/gaia_info_update_service.cc#newcode184 chrome/browser/profiles/gaia_info_update_service.cc:184: profile_ = NULL; ...
6 years, 9 months ago (2014-03-24 17:49:29 UTC) #3
noms (inactive)
lgtm, but as a heads up, the NoMigration test keeps failing.
6 years, 9 months ago (2014-03-26 14:40:43 UTC) #4
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 9 months ago (2014-03-28 20:09:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/196243009/200001
6 years, 9 months ago (2014-03-28 20:11:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 21:53:15 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-28 21:53:17 UTC) #8
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 8 months ago (2014-03-31 15:31:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/196243009/220001
6 years, 8 months ago (2014-03-31 15:31:34 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 15:45:56 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-03-31 15:45:57 UTC) #12
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 8 months ago (2014-03-31 17:19:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/196243009/220001
6 years, 8 months ago (2014-03-31 17:20:44 UTC) #14
commit-bot: I haz the power
Change committed as 260630
6 years, 8 months ago (2014-03-31 20:24:10 UTC) #15
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 8 months ago (2014-04-02 02:12:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/196243009/260001
6 years, 8 months ago (2014-04-02 02:17:25 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 05:37:29 UTC) #18
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58969
6 years, 8 months ago (2014-04-02 05:37:30 UTC) #19
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 8 months ago (2014-04-02 14:58:14 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/196243009/300001
6 years, 8 months ago (2014-04-02 14:58:27 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 21:02:22 UTC) #22
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=60529
6 years, 8 months ago (2014-04-02 21:02:22 UTC) #23
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 8 months ago (2014-04-02 21:21:41 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/196243009/300001
6 years, 8 months ago (2014-04-02 21:22:37 UTC) #25
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 07:42:37 UTC) #26
Message was sent while issue was closed. 
Change committed as 261309

Powered by Google App Engine
This is Rietveld 408576698