Fix CLI SDK option config timing (#26129).

Fix CLI SDK option config timing (#26129).

Fixes: https://github.com/dart-lang/sdk/issues/26129

The issue was that we were creating the SDK and populating its options (notably `strong-mode`) *before* options processors were called.  The result was that client code analysis contexts and SDK contexts were getting configured differently causing confusion when client code was getting analyzed with a non-strong-mode SDK.

BUG=
R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/79139687252e4b6edc7a01db24cf5f4e30b5469b

[pquitslund, 2016-05-10 18:10:42]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com

[pquitslund, 2016-05-10 18:10:42]

Paul: I'd appreciate a sanity check.  I *believe* this preserves your batch mode
logic.  Please let me know if you think otherwise!

[Paul Berry, 2016-05-10 18:33:24]

lgtm.

Note: the acid test for whether the batch mode logic is preserved is to run the
analyzer build bot, since it's the most demanding client of batch mode.  You can
run it using:

./tools/test.py -aia32 --host-checked --mode release --compiler dart2analyzer
--runtime none --progress color --report --tasks=4

(Note: drop the "-aia32" if you do a 64-bit build)

https://codereview.chromium.org/1962403002/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/1962403002/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:585: void _setupSdk({String path}) {
Nit: it seems weird for [path] to be an optional parameter, when AFAICT the only
caller always passes a value for it.

[pquitslund, 2016-05-10 20:35:45]

Description was changed from

==========
Fix CLI SDK option config timing (#26129).

Fixes: https://github.com/dart-lang/sdk/issues/26129

The issue was that we were creating the SDK and populating its options (notably
`strong-mode`) *before* options processors were called.  The result was that
client code analysis contexts and SDK contexts were getting configured
differently causing confusion when client code was getting analyzed with a
non-strong-mode SDK.

BUG=
==========

to

==========
Fix CLI SDK option config timing (#26129).

Fixes: https://github.com/dart-lang/sdk/issues/26129

The issue was that we were creating the SDK and populating its options (notably
`strong-mode`) *before* options processors were called.  The result was that
client code analysis contexts and SDK contexts were getting configured
differently causing confusion when client code was getting analyzed with a
non-strong-mode SDK.

BUG=
R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/79139687252e4b6edc7a01db24cf5f4e30b5469b
==========

[pquitslund, 2016-05-10 20:35:47]

Committed patchset #1 (id:1) manually as
79139687252e4b6edc7a01db24cf5f4e30b5469b (presubmit successful).

[pquitslund, 2016-05-10 21:22:39]

https://codereview.chromium.org/1962403002/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/1962403002/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:585: void _setupSdk({String path}) {
On 2016/05/10 18:33:24, Paul Berry wrote:
> Nit: it seems weird for [path] to be an optional parameter, when AFAICT the
only
> caller always passes a value for it.

Yeah.  I just really like named params! Would that I could make them required. 
After merging with master I did away with this anyway since I need the options
handy to scan source files to check whether to use summaries.

Thanks!