Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: blimp/client/feature/navigation_feature_unittest.cc

Issue 1962393004: Added a debug info UI for Blimp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactored menu into ToolbarMenu Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/feature/navigation_feature_unittest.cc
diff --git a/blimp/client/feature/navigation_feature_unittest.cc b/blimp/client/feature/navigation_feature_unittest.cc
index 8a5c0ba692a6496ef659852ae7ef437f3944248d..be97fbcdd7219b0cc223919adc6a904ca59f624c 100644
--- a/blimp/client/feature/navigation_feature_unittest.cc
+++ b/blimp/client/feature/navigation_feature_unittest.cc
@@ -8,9 +8,11 @@
#include "base/logging.h"
#include "base/memory/ptr_util.h"
+#include "base/message_loop/message_loop.h"
#include "blimp/client/feature/mock_navigation_feature_delegate.h"
#include "blimp/common/create_blimp_message.h"
#include "blimp/common/proto/blimp_message.pb.h"
+#include "blimp/net/blimp_connection_details.h"
#include "blimp/net/test_common.h"
#include "net/base/net_errors.h"
#include "net/base/test_completion_callback.h"
@@ -70,9 +72,28 @@ MATCHER_P(EqualsNavigateReload, tab_id, "") {
arg.navigation().type() == NavigationMessage::RELOAD;
}
+class MockNetworkActivityObserver : public NetworkActivityObserver {
+ public:
+ MockNetworkActivityObserver() : weak_factory_(this) {}
+
+ void UpdateDebugInfo(int received, int sent, int commits) override {}
+
+ base::WeakPtr<MockNetworkActivityObserver> GetWeakPtr() {
+ return weak_factory_.GetWeakPtr();
+ }
+
+ private:
+ base::WeakPtrFactory<MockNetworkActivityObserver> weak_factory_;
+};
+
class NavigationFeatureTest : public testing::Test {
public:
- NavigationFeatureTest() : out_processor_(nullptr) {}
+ NavigationFeatureTest()
+ : out_processor_(nullptr),
+ feature_(new BlimpConnectionDetails(
+ MockNetworkActivityObserver().GetWeakPtr(),
+ message_loop_.task_runner(),
+ message_loop_.task_runner())) {}
void SetUp() override {
out_processor_ = new MockBlimpMessageProcessor();
@@ -89,6 +110,8 @@ class NavigationFeatureTest : public testing::Test {
MockNavigationFeatureDelegate delegate1_;
MockNavigationFeatureDelegate delegate2_;
+ base::MessageLoop message_loop_;
+
NavigationFeature feature_;
};

Powered by Google App Engine
This is Rietveld 408576698