blimp/engine/session/blimp_engine_session.cc - Issue 1962393004: Added a debug info UI for Blimp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/session/blimp_engine_session.cc

Issue 1962393004: Added a debug info UI for Blimp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Built debug UI Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/engine/session/blimp_engine_session.cc

diff --git a/blimp/engine/session/blimp_engine_session.cc b/blimp/engine/session/blimp_engine_session.cc

index 037f3e809d30393841b0a99c16204d2f07593f35..bc17809e8ec982fb7fc3475132ed179fe2fd56d7 100644

--- a/blimp/engine/session/blimp_engine_session.cc

+++ b/blimp/engine/session/blimp_engine_session.cc

@@ -189,6 +189,7 @@ void EngineNetworkComponents::HandleConnection(

std::unique_ptr<BlimpConnection> connection) {

// Observe |connection| for disconnection events.

connection->AddConnectionErrorObserver(this);

+ connection->SetBlimpConnectionDetails(nullptr);

Khushal 2016/05/18 00:23:00 Don't really need to do this here. They already ha

shaktisahu 2016/05/19 21:39:18 Done.

connection_handler_->HandleConnection(std::move(connection));

}