Chromium Code Reviews| Index: blimp/client/session/blimp_client_session.cc |
| diff --git a/blimp/client/session/blimp_client_session.cc b/blimp/client/session/blimp_client_session.cc |
| index 760842abc72bb5cd32e63d9b1f4782aa071cb4d0..e9582408d3a89b2d44f04e0efff9f73cf97f8bcb 100644 |
| --- a/blimp/client/session/blimp_client_session.cc |
| +++ b/blimp/client/session/blimp_client_session.cc |
| @@ -73,7 +73,8 @@ class ClientNetworkComponents : public ConnectionHandler, |
| public: |
| // Can be created on any thread. |
| explicit ClientNetworkComponents( |
|
Kevin M
2016/05/24 22:56:40
Not "explicit"
|
| - std::unique_ptr<NetworkEventObserver> observer); |
| + std::unique_ptr<NetworkEventObserver> observer, |
| + BlimpConnectionStatistics* blimp_connection_statistics); |
|
Kevin M
2016/05/24 22:56:40
Should take a unique_ptr<> if we are passing owner
|
| ~ClientNetworkComponents() override; |
| // Sets up network components. |
| @@ -95,14 +96,17 @@ class ClientNetworkComponents : public ConnectionHandler, |
| std::unique_ptr<BrowserConnectionHandler> connection_handler_; |
| std::unique_ptr<ClientConnectionManager> connection_manager_; |
| std::unique_ptr<NetworkEventObserver> network_observer_; |
| + std::unique_ptr<BlimpConnectionStatistics> connection_statistics_; |
| DISALLOW_COPY_AND_ASSIGN(ClientNetworkComponents); |
| }; |
| ClientNetworkComponents::ClientNetworkComponents( |
| - std::unique_ptr<NetworkEventObserver> network_observer) |
| + std::unique_ptr<NetworkEventObserver> network_observer, |
| + BlimpConnectionStatistics* statistics) |
| : connection_handler_(new BrowserConnectionHandler), |
| - network_observer_(std::move(network_observer)) {} |
| + network_observer_(std::move(network_observer)), |
| + connection_statistics_(statistics) {} |
|
Kevin M
2016/05/24 22:56:40
DCHECK(statistics)
|
| ClientNetworkComponents::~ClientNetworkComponents() {} |
| @@ -121,12 +125,13 @@ void ClientNetworkComponents::ConnectWithAssignment( |
| case Assignment::SSL: |
| DCHECK(assignment.cert); |
| connection_manager_->AddTransport(base::WrapUnique(new SSLClientTransport( |
| - assignment.engine_endpoint, std::move(assignment.cert), nullptr))); |
| + assignment.engine_endpoint, std::move(assignment.cert), |
| + connection_statistics_.get(), nullptr))); |
| transport_type = "SSL"; |
| break; |
| case Assignment::TCP: |
| - connection_manager_->AddTransport(base::WrapUnique( |
| - new TCPClientTransport(assignment.engine_endpoint, nullptr))); |
| + connection_manager_->AddTransport(base::WrapUnique(new TCPClientTransport( |
| + assignment.engine_endpoint, connection_statistics_.get(), nullptr))); |
| transport_type = "TCP"; |
| break; |
| case Assignment::UNKNOWN: |
| @@ -166,13 +171,14 @@ BlimpClientSession::BlimpClientSession(const GURL& assigner_endpoint) |
| render_widget_feature_(new RenderWidgetFeature), |
| settings_feature_(new SettingsFeature), |
| weak_factory_(this) { |
| - net_components_.reset(new ClientNetworkComponents( |
| - base::WrapUnique(new CrossThreadNetworkEventObserver( |
| - weak_factory_.GetWeakPtr(), |
| - base::SequencedTaskRunnerHandle::Get())))); |
| base::Thread::Options options; |
| options.message_loop_type = base::MessageLoop::TYPE_IO; |
| io_thread_.StartWithOptions(options); |
| + blimp_connection_statistics_ = new BlimpConnectionStatistics(); |
| + net_components_.reset(new ClientNetworkComponents( |
| + base::WrapUnique(new CrossThreadNetworkEventObserver( |
| + weak_factory_.GetWeakPtr(), base::SequencedTaskRunnerHandle::Get())), |
| + blimp_connection_statistics_)); |
| assignment_source_.reset(new AssignmentSource( |
| assigner_endpoint, io_thread_.task_runner(), io_thread_.task_runner())); |
| @@ -275,5 +281,10 @@ SettingsFeature* BlimpClientSession::GetSettingsFeature() const { |
| return settings_feature_.get(); |
| } |
| +BlimpConnectionStatistics* BlimpClientSession::GetBlimpConnectionStatistics() |
| + const { |
| + return blimp_connection_statistics_; |
| +} |
| + |
| } // namespace client |
| } // namespace blimp |