Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: blimp/net/stream_packet_writer.h

Issue 1962393004: Added a debug info UI for Blimp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Kevin's comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/stream_packet_writer.h
diff --git a/blimp/net/stream_packet_writer.h b/blimp/net/stream_packet_writer.h
index a13711b84009ea85e57c9207a927e0a474acd842..03b05a4847692e3801ec323f3ba519e0f1beb5cb 100644
--- a/blimp/net/stream_packet_writer.h
+++ b/blimp/net/stream_packet_writer.h
@@ -21,6 +21,7 @@ class StreamSocket;
} // namespace net
namespace blimp {
+class BlimpConnectionStatistics;
// Writes opaque length-prefixed packets to a StreamSocket.
// The header segment is 32-bit, encoded in network byte order.
@@ -30,7 +31,8 @@ class BLIMP_NET_EXPORT StreamPacketWriter : public PacketWriter {
public:
// |socket|: The socket to write packets to. The caller must ensure |socket|
// is valid while the reader is in-use (see ReadPacket below).
Kevin M 2016/05/24 21:49:00 Document |statistics| and lifetime requirements
- explicit StreamPacketWriter(net::StreamSocket* socket);
+ explicit StreamPacketWriter(net::StreamSocket* socket,
Kevin M 2016/05/24 21:49:01 Remove "explicit" for >1 arg constructors, in here
shaktisahu 2016/05/24 22:42:14 Done.
+ BlimpConnectionStatistics* statistics);
~StreamPacketWriter() override;
@@ -67,6 +69,7 @@ class BLIMP_NET_EXPORT StreamPacketWriter : public PacketWriter {
scoped_refptr<net::DrainableIOBuffer> payload_buffer_;
scoped_refptr<net::DrainableIOBuffer> header_buffer_;
net::CompletionCallback callback_;
+ BlimpConnectionStatistics* statistics_;
base::WeakPtrFactory<StreamPacketWriter> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698