Added a debug info UI for Blimp

blimp/net/blimp_connection.cc

Index: blimp/net/blimp_connection.cc
diff --git a/blimp/net/blimp_connection.cc b/blimp/net/blimp_connection.cc
index e8f3c68cc376131814ccd41bcf308c8950a2ce91..2a135af64bd989698fbbe9f828298a2ac702a4da 100644
--- a/blimp/net/blimp_connection.cc
+++ b/blimp/net/blimp_connection.cc
@@ -11,6 +11,7 @@
 #include "base/message_loop/message_loop.h"
 #include "blimp/common/logging.h"
 #include "blimp/common/proto/blimp_message.pb.h"
+#include "blimp/net/blimp_connection_statistics.h"
 #include "blimp/net/blimp_message_processor.h"
 #include "blimp/net/blimp_message_pump.h"
 #include "blimp/net/common.h"
@@ -36,6 +37,11 @@ class BlimpMessageSender : public BlimpMessageProcessor {
   void ProcessMessage(std::unique_ptr<BlimpMessage> message,
                       const net::CompletionCallback& callback) override;
 
+  void SetBlimpConnectionStatistics(BlimpConnectionStatistics* statistics) {
+    DCHECK(writer_);

[Kevin M, 2016/05/24 01:02:01]

Not needed - the constructor guarantees that writer_ cannot be null.

[shaktisahu, 2016/05/24 21:02:44]

Removed function since we are passing in constructor

+    writer_->set_blimp_connection_statistics(statistics);
+  }
+
  private:
   void OnWritePacketComplete(int result);
 
@@ -136,6 +142,14 @@ void BlimpConnection::SetIncomingMessageProcessor(
   message_pump_->SetMessageProcessor(processor);
 }
 
+void BlimpConnection::SetBlimpConnectionStatistics(

[Kevin M, 2016/05/24 01:02:01]

We should be setting this at stream creation time, at the StreamPacketReader
level.

So that means:
1) have the TCPClientTransport and SSLClientTransport factories take a
BlimpConnectionStatistics*.

2) pass the pointer in to the StreamPacketReader and StreamPacketWriter objects
at creation time.

We don't have to expose any virtual getters to the packet reader or packet
writer that way, nor do we need to do any kind of two-phase initialization where
we connect and *then* we set it. A nice thing about requiring a statistics
object on construction is that we don't have to check for the existence of the
statistics object before dereferencing it - we'll know for a fact that the
statistics object is set.

+    BlimpConnectionStatistics* statistics) {
+  message_pump_->SetBlimpConnectionStatistics(statistics);
+  BlimpMessageSender* sender =
+      static_cast<BlimpMessageSender*>(outgoing_msg_processor_.get());

[Kevin M, 2016/05/24 01:02:01]

See previous comment about making outgoing_msg_processor_ a BlimpMessageSender.

+  sender->SetBlimpConnectionStatistics(statistics);
+}
+
 BlimpMessageProcessor* BlimpConnection::GetOutgoingMessageProcessor() {
   return outgoing_msg_processor_.get();
 }