Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2922)

Unified Diff: blimp/client/feature/navigation_feature.cc

Issue 1962393004: Added a debug info UI for Blimp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/feature/navigation_feature.cc
diff --git a/blimp/client/feature/navigation_feature.cc b/blimp/client/feature/navigation_feature.cc
index 34922363c31c9f7ba0b82d393e55fdf79b318457..b20d1c51312cb1766067afddabf0170ea81427fb 100644
--- a/blimp/client/feature/navigation_feature.cc
+++ b/blimp/client/feature/navigation_feature.cc
@@ -19,7 +19,8 @@
namespace blimp {
namespace client {
-NavigationFeature::NavigationFeature() {}
+NavigationFeature::NavigationFeature(BlimpConnectionDetails* details)
+ : connection_details_(details) {}
NavigationFeature::~NavigationFeature() {}
@@ -64,6 +65,7 @@ void NavigationFeature::NavigateToUrlText(int tab_id,
CreateBlimpMessage(&navigation_message, tab_id);
navigation_message->set_type(NavigationMessage::LOAD_URL);
navigation_message->mutable_load_url()->set_url(url.spec());
+ connection_details_->ResetStats();
Kevin M 2016/05/10 23:54:24 Consider moving the data collection policy out of
shaktisahu 2016/05/16 05:41:38 Keeping this here as I can't use NetLog
outgoing_message_processor_->ProcessMessage(std::move(blimp_message),
net::CompletionCallback());
}
@@ -74,6 +76,7 @@ void NavigationFeature::Reload(int tab_id) {
CreateBlimpMessage(&navigation_message, tab_id);
navigation_message->set_type(NavigationMessage::RELOAD);
+ connection_details_->ResetStats();
outgoing_message_processor_->ProcessMessage(std::move(blimp_message),
net::CompletionCallback());
}
@@ -84,6 +87,7 @@ void NavigationFeature::GoForward(int tab_id) {
CreateBlimpMessage(&navigation_message, tab_id);
navigation_message->set_type(NavigationMessage::GO_FORWARD);
+ connection_details_->ResetStats();
outgoing_message_processor_->ProcessMessage(std::move(blimp_message),
net::CompletionCallback());
}
@@ -94,6 +98,7 @@ void NavigationFeature::GoBack(int tab_id) {
CreateBlimpMessage(&navigation_message, tab_id);
navigation_message->set_type(NavigationMessage::GO_BACK);
+ connection_details_->ResetStats();
outgoing_message_processor_->ProcessMessage(std::move(blimp_message),
net::CompletionCallback());
}

Powered by Google App Engine
This is Rietveld 408576698