Added a debug info UI for Blimp

blimp/net/tcp_engine_transport.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/net/tcp_engine_transport.h"
 
 #include <memory>
 
 #include "base/callback.h"
 #include "base/callback_helpers.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
+#include "blimp/net/blimp_connection_statistics.h"
 #include "blimp/net/stream_socket_connection.h"
 #include "net/socket/stream_socket.h"
 #include "net/socket/tcp_server_socket.h"
 
 namespace blimp {
 
 TCPEngineTransport::TCPEngineTransport(const net::IPEndPoint& address,
                                        net::NetLog* net_log)
     : address_(address), net_log_(net_log) {}
 
@@ skipping 29 matching lines @@
     server_socket_.reset();
   }
 
   base::MessageLoop::current()->PostTask(FROM_HERE,
                                          base::Bind(callback, result));
 }
 
 std::unique_ptr<BlimpConnection> TCPEngineTransport::TakeConnection() {
   DCHECK(connect_callback_.is_null());
   DCHECK(accepted_socket_);
-  return base::WrapUnique(
-      new StreamSocketConnection(std::move(accepted_socket_)));
+  return base::WrapUnique(new StreamSocketConnection(
+      std::move(accepted_socket_), new BlimpConnectionStatistics));

[Kevin M, 2016/05/24 21:49:01]

This leaks the statistics object.

Maybe consider making the statistics object refcounted. That takes care of any
potential ownership issues and gives you the ability to pass in a valid but
unused object such as the case we have here.

 }
 
 const char* TCPEngineTransport::GetName() const {
   return "TCP";
 }
 
 int TCPEngineTransport::GetLocalAddress(net::IPEndPoint* address) const {
   DCHECK(server_socket_);
   return server_socket_->GetLocalAddress(address);
 }
 
 void TCPEngineTransport::OnTCPConnectAccepted(int result) {
   DCHECK_NE(net::ERR_IO_PENDING, result);
   DCHECK(accepted_socket_);
   if (result != net::OK) {
     accepted_socket_.reset();
   }
   base::ResetAndReturn(&connect_callback_).Run(result);
 }
 
 }  // namespace blimp