Added a debug info UI for Blimp

blimp/net/compressed_packet_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/ptr_util.h"
 #include "base/rand_util.h"
+#include "base/run_loop.h"
 #include "base/sys_byteorder.h"
+#include "blimp/net/blimp_connection_statistics.h"
 #include "blimp/net/common.h"
 #include "blimp/net/compressed_packet_reader.h"
 #include "blimp/net/compressed_packet_writer.h"
 #include "blimp/net/test_common.h"
 #include "net/base/test_completion_callback.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::_;
 using testing::DoAll;
@@ skipping 22 matching lines @@
   ASSERT_TRUE(src_buf);
   ASSERT_EQ(0, dest_buf->offset());
   src_buf->SetOffset(0);
   dest_buf->SetCapacity(src_buf->BytesRemaining());
   memcpy(dest_buf->data(), src_buf->data(), src_buf->BytesRemaining());
 }
 
 class CompressedPacketTest : public testing::Test {
  public:
   CompressedPacketTest()
-      : mock_reader_(new MockPacketReader),
+      : blimp_connection_statistics_(new BlimpConnectionStatistics),
+        mock_reader_(new MockPacketReader),
         mock_writer_(new MockPacketWriter),
         compressed_reader_(
             new CompressedPacketReader(base::WrapUnique(mock_reader_))),
         compressed_writer_(
-            new CompressedPacketWriter(base::WrapUnique(mock_writer_))) {}
+            new CompressedPacketWriter(base::WrapUnique(mock_writer_))) {
+    compressed_reader_->set_blimp_connection_statistics(
+        blimp_connection_statistics_.get());
+    compressed_writer_->set_blimp_connection_statistics(
+        blimp_connection_statistics_.get());
+  }
   ~CompressedPacketTest() override {}
 
  protected:
   // Returns the compressed result of |content|.
   std::string Compress(const std::string& content) {
     scoped_refptr<net::StringIOBuffer> content_str_buf(
         new net::StringIOBuffer(content));
     scoped_refptr<net::DrainableIOBuffer> content_buf(
         new net::DrainableIOBuffer(content_str_buf.get(),
                                    content_str_buf->size()));
@@ skipping 25 matching lines @@
     compressed_reader_->ReadPacket(decompressed_buf,
                                    completion_cb_2.callback());
     int size = completion_cb_2.WaitForResult();
     return std::string(decompressed_buf->data(), size);
   }
 
   bool CheckRoundTrip(const std::string& content) {
     return Decompress(Compress(content)) == content;
   }
 
+  std::unique_ptr<BlimpConnectionStatistics> blimp_connection_statistics_;

[Kevin M, 2016/05/24 01:02:01]

suggestion: make it a regular (non-unique_ptr) field?

[shaktisahu, 2016/05/24 21:02:45]

Removed from this file

   MockPacketReader* mock_reader_;
   MockPacketWriter* mock_writer_;
   std::unique_ptr<CompressedPacketReader> compressed_reader_;
   std::unique_ptr<CompressedPacketWriter> compressed_writer_;
   testing::InSequence s;
 };
 
 TEST_F(CompressedPacketTest, Empty) {
   EXPECT_TRUE(CheckRoundTrip("1234"));
+  EXPECT_TRUE(CheckRoundTrip("1234"));

[Kevin M, 2016/05/24 01:02:02]

Why duplicate this line?

[shaktisahu, 2016/05/24 21:02:45]

Done.

   EXPECT_TRUE(CheckRoundTrip(""));
   EXPECT_TRUE(CheckRoundTrip("1234"));
 }
 
+TEST_F(CompressedPacketTest, StatisticsCollection) {
+  std::string source = "AAAAAAAAAAAAAAAAAAAAAAAAA";
+  std::string compressed = Compress(source);
+  std::string decompressed = Decompress(compressed);
+  EXPECT_EQ((int)compressed.size(),

[Kevin M, 2016/05/24 01:02:01]

nit: use static_cast<> instead of C-style cast.

[shaktisahu, 2016/05/24 21:02:45]

Done.

+            blimp_connection_statistics_->Get(
+                BlimpConnectionStatistics::BYTES_RECEIVED));
+  EXPECT_EQ((int)compressed.size(), blimp_connection_statistics_->Get(
+                                        BlimpConnectionStatistics::BYTES_SENT));

[Kevin M, 2016/05/24 01:02:01]

This formatting looks a little off, run git cl format?

[shaktisahu, 2016/05/24 21:02:45]

Done.

+}
+
 TEST_F(CompressedPacketTest, Simple) {
   std::string source = "AAAAAAAAAAAAAAAAAAAAAAAAA";
   std::string compressed = Compress(source);
   std::string decompressed = Decompress(compressed);
   EXPECT_GT(source.size(), compressed.size());
   EXPECT_EQ(source, decompressed);
 }
 
 TEST_F(CompressedPacketTest, DisjointSequences) {
   EXPECT_TRUE(CheckRoundTrip("1234"));
@@ skipping 94 matching lines @@
           DoAll(CopyBuffer<0>(compressed_buf),
                 InvokeCompletionCallback<1>(compressed_buf->BytesRemaining())));
   net::TestCompletionCallback completion_cb_2;
   compressed_reader_->ReadPacket(make_scoped_refptr(new net::GrowableIOBuffer),
                                  completion_cb_2.callback());
   EXPECT_EQ(net::ERR_UNEXPECTED, completion_cb_2.WaitForResult());
 }
 
 }  // namespace
 }  // namespace blimp