Added a debug info UI for Blimp

blimp/net/blimp_connection.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_NET_BLIMP_CONNECTION_H_
 #define BLIMP_NET_BLIMP_CONNECTION_H_
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/observer_list.h"
 #include "blimp/net/blimp_net_export.h"
 #include "blimp/net/connection_error_observer.h"
 
 namespace blimp {
 
+class BlimpConnectionStatistics;
 class BlimpMessageProcessor;
 class BlimpMessagePump;
 class PacketReader;
 class PacketWriter;
 
 // Encapsulates the state and logic used to exchange BlimpMessages over
 // a network connection.
 class BLIMP_NET_EXPORT BlimpConnection : public ConnectionErrorObserver {
  public:
   BlimpConnection(std::unique_ptr<PacketReader> reader,
                   std::unique_ptr<PacketWriter> writer);
 
   ~BlimpConnection() override;
 
   // Adds |observer| to the connection's error observer list.
   virtual void AddConnectionErrorObserver(ConnectionErrorObserver* observer);
 
   // Removes |observer| from the connection's error observer list.
   virtual void RemoveConnectionErrorObserver(ConnectionErrorObserver* observer);
 
   // Sets the processor which will take incoming messages for this connection.
   // Can be set multiple times, but previously set processors are discarded.
   // Caller retains the ownership of |processor|.
   virtual void SetIncomingMessageProcessor(BlimpMessageProcessor* processor);
 
   // Gets a processor for BrowserSession->BlimpConnection message routing.
   virtual BlimpMessageProcessor* GetOutgoingMessageProcessor();
 
+  void SetBlimpConnectionStatistics(BlimpConnectionStatistics* statistics);

[Kevin M, 2016/05/20 01:02:03]

Does it make sense to *not* have connection statistics? Can this be moved into
the constructor?

[shaktisahu, 2016/05/22 22:36:56]

No. The BlimpConnection is built at too deep in the call stack where I don't
have access. I have to pass this all the way from BlimpClientSession to specific
PacketReader/PacketWriter implementation, which is pretty terrible. The other
alternative is to make this class a singleton but singletons are not good
patterns in general.

+
  protected:
   BlimpConnection();
 
   // ConnectionErrorObserver implementation.
   void OnConnectionError(int error) override;
 
  private:
   std::unique_ptr<PacketReader> reader_;
   std::unique_ptr<BlimpMessagePump> message_pump_;
   std::unique_ptr<PacketWriter> writer_;
   std::unique_ptr<BlimpMessageProcessor> outgoing_msg_processor_;
   base::ObserverList<ConnectionErrorObserver> error_observers_;
 
   DISALLOW_COPY_AND_ASSIGN(BlimpConnection);
 };
 
 }  // namespace blimp
 
 #endif  // BLIMP_NET_BLIMP_CONNECTION_H_