Added a debug info UI for Blimp

blimp/client/feature/compositor/blimp_compositor_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_CLIENT_FEATURE_COMPOSITOR_BLIMP_COMPOSITOR_MANAGER_H_
 #define BLIMP_CLIENT_FEATURE_COMPOSITOR_BLIMP_COMPOSITOR_MANAGER_H_
 
 #include "base/macros.h"
 #include "blimp/client/feature/compositor/blimp_compositor.h"
 #include "blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.h"
 #include "blimp/client/feature/render_widget_feature.h"
 #include "cc/trees/layer_tree_settings.h"
 
 namespace blimp {
 namespace client {
 
 class ClientImageSerializationProcessor;
 
 class BlimpCompositorManagerClient {

[Kevin M, 2016/05/20 01:02:03]

This should probably be called a Delegate, not a Client.

[shaktisahu, 2016/05/22 22:36:56]

Hmm... Sounds okay to me. Anyway this is not my changes and don't want to change
it.

  public:
   virtual void OnSwapBuffersCompleted() = 0;
+  virtual void DidCommitAndDrawFrame() = 0;

[Kevin M, 2016/05/20 01:02:03]

Can we standardize our naming here, so it's all OnXYZ or DidXYZ, but not both?

[shaktisahu, 2016/05/22 22:36:56]

This is the same callback propagated all the way from cc layer. May be sometimes
one convention makes more sense than the other? e.g. when there are more than
one verb in the method name :)

 };
 
 // The BlimpCompositorManager manages multiple BlimpCompositor instances, each
 // mapped to a render widget on the engine. The compositor corresponding to
 // the render widget initialized on the engine will be the |active_compositor_|.
 // Only the |active_compositor_| holds the accelerated widget and builds the
 // output surface from this widget to draw to the view. All events from the
 // native view are forwarded to this compositor.
 class BlimpCompositorManager
     : public RenderWidgetFeature::RenderWidgetFeatureDelegate,
@@ skipping 31 matching lines @@
   // RenderWidgetFeatureDelegate implementation.
   void OnRenderWidgetCreated(int render_widget_id) override;
   void OnRenderWidgetInitialized(int render_widget_id) override;
   void OnRenderWidgetDeleted(int render_widget_id) override;
   void OnCompositorMessageReceived(
       int render_widget_id,
       std::unique_ptr<cc::proto::CompositorMessage> message) override;
 
   // BlimpCompositorClient implementation.
   void DidCompleteSwapBuffers() override;
+  void DidCommitAndDrawFrame() override;
   cc::LayerTreeSettings* GetLayerTreeSettings() override;
   scoped_refptr<base::SingleThreadTaskRunner>
   GetCompositorTaskRunner() override;
   cc::TaskGraphRunner* GetTaskGraphRunner() override;
   gpu::GpuMemoryBufferManager* GetGpuMemoryBufferManager() override;
   cc::ImageSerializationProcessor* GetImageSerializationProcessor() override;
   void SendWebGestureEvent(
       int render_widget_id,
       const blink::WebGestureEvent& gesture_event) override;
   void SendCompositorMessage(
@@ skipping 31 matching lines @@
   RenderWidgetFeature* render_widget_feature_;
   BlimpCompositorManagerClient* client_;
 
   DISALLOW_COPY_AND_ASSIGN(BlimpCompositorManager);
 };
 
 }  // namespace client
 }  // namespace blimp
 
 #endif  // BLIMP_CLIENT_FEATURE_COMPOSITOR_BLIMP_COMPOSITOR_MANAGER_H_