Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3846)

Unified Diff: chrome/browser/ui/translate/translate_bubble_view_state_transition.h

Issue 1962393003: log the click activate/deactive of translate icon on location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adjust for review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/translate/translate_bubble_view_state_transition.h
diff --git a/chrome/browser/ui/translate/translate_bubble_view_state_transition.h b/chrome/browser/ui/translate/translate_bubble_view_state_transition.h
index d99bcf7d26a6009b3bf8b32ce10010d2d63118ee..5c0410c755192986c2e4dfd8bc5ffcb033e39de7 100644
--- a/chrome/browser/ui/translate/translate_bubble_view_state_transition.h
+++ b/chrome/browser/ui/translate/translate_bubble_view_state_transition.h
@@ -62,9 +62,17 @@ enum TranslateBubbleUiEvent {
// The user changed the "Target language".
TARGET_LANGUAGE_MENU_CLICKED,
+ // The user activate the translate page action icon.
msw 2016/05/12 17:29:41 nit: activated
ftang 2016/05/12 18:38:08 Done.
+ PAGE_ACTION_ICON_ACTIVATED,
+
+ // The user deactivate the translate page action icon.
msw 2016/05/12 17:29:41 nit: deactivated
ftang 2016/05/12 18:38:08 Done.
+ PAGE_ACTION_ICON_DEACTIVATED,
+
TRANSLATE_BUBBLE_UI_EVENT_MAX
};
+extern const char kTranslateBubbleUIEvent[];
+
} // namespace translate
// The class which manages the transition of the view state of the Translate

Powered by Google App Engine
This is Rietveld 408576698