Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: content/shell/renderer/layout_test/layout_test_content_renderer_client.cc

Issue 1962393002: Destroy WebWidgetTestClient when its WebWidget is destroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: keep the TODO Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/renderer/layout_test/layout_test_content_renderer_client .h" 5 #include "content/shell/renderer/layout_test/layout_test_content_renderer_client .h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/debug/debugger.h" 9 #include "base/debug/debugger.h"
10 #include "components/test_runner/mock_credential_manager_client.h" 10 #include "components/test_runner/mock_credential_manager_client.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 ShellContentRendererClient::RenderThreadStarted(); 102 ShellContentRendererClient::RenderThreadStarted();
103 shell_observer_.reset(new LayoutTestRenderThreadObserver()); 103 shell_observer_.reset(new LayoutTestRenderThreadObserver());
104 } 104 }
105 105
106 void LayoutTestContentRendererClient::RenderFrameCreated( 106 void LayoutTestContentRendererClient::RenderFrameCreated(
107 RenderFrame* render_frame) { 107 RenderFrame* render_frame) {
108 test_runner::WebFrameTestProxyBase* frame_proxy = 108 test_runner::WebFrameTestProxyBase* frame_proxy =
109 GetWebFrameTestProxyBase(render_frame); 109 GetWebFrameTestProxyBase(render_frame);
110 frame_proxy->set_web_frame(render_frame->GetWebFrame()); 110 frame_proxy->set_web_frame(render_frame->GetWebFrame());
111 new LayoutTestRenderFrameObserver(render_frame); 111 new LayoutTestRenderFrameObserver(render_frame);
112
113 // TODO(lfg): We should fix the TestProxy to track the WebWidgets on every
114 // local root in WebFrameTestProxy instead of having only the WebWidget for
115 // the main frame in WebTestProxy.
116 test_runner::WebTestProxyBase* proxy =
117 GetWebTestProxyBase(render_frame->GetRenderView());
118 WebLocalFrame* frame = render_frame->GetWebFrame();
119 if (!frame->parent())
120 proxy->set_web_widget(frame->frameWidget());
121 } 112 }
122 113
123 void LayoutTestContentRendererClient::RenderViewCreated( 114 void LayoutTestContentRendererClient::RenderViewCreated(
124 RenderView* render_view) { 115 RenderView* render_view) {
125 new ShellRenderViewObserver(render_view); 116 new ShellRenderViewObserver(render_view);
126 117
127 test_runner::WebTestProxyBase* proxy = GetWebTestProxyBase(render_view); 118 test_runner::WebTestProxyBase* proxy = GetWebTestProxyBase(render_view);
128 proxy->set_web_view(render_view->GetWebView()); 119 proxy->set_web_view(render_view->GetWebView());
120 // TODO(lfg): We should fix the TestProxy to track the WebWidgets on every
121 // local root in WebFrameTestProxy instead of having only the WebWidget for
122 // the main frame in WebTestProxy.
123 proxy->set_web_widget(render_view->GetWebView()->widget());
129 proxy->Reset(); 124 proxy->Reset();
130 proxy->SetSendWheelGestures(UseGestureBasedWheelScrolling()); 125 proxy->SetSendWheelGestures(UseGestureBasedWheelScrolling());
131 126
132 BlinkTestRunner* test_runner = BlinkTestRunner::Get(render_view); 127 BlinkTestRunner* test_runner = BlinkTestRunner::Get(render_view);
133 test_runner->Reset(false /* for_new_test */); 128 test_runner->Reset(false /* for_new_test */);
134 129
135 LayoutTestRenderThreadObserver::GetInstance() 130 LayoutTestRenderThreadObserver::GetInstance()
136 ->test_interfaces() 131 ->test_interfaces()
137 ->TestRunner() 132 ->TestRunner()
138 ->InitializeWebViewWithMocks(render_view->GetWebView()); 133 ->InitializeWebViewWithMocks(render_view->GetWebView());
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 LayoutTestContentRendererClient::CreateMediaStreamRendererFactory() { 197 LayoutTestContentRendererClient::CreateMediaStreamRendererFactory() {
203 #if defined(ENABLE_WEBRTC) 198 #if defined(ENABLE_WEBRTC)
204 return std::unique_ptr<MediaStreamRendererFactory>( 199 return std::unique_ptr<MediaStreamRendererFactory>(
205 new TestMediaStreamRendererFactory()); 200 new TestMediaStreamRendererFactory());
206 #else 201 #else
207 return nullptr; 202 return nullptr;
208 #endif 203 #endif
209 } 204 }
210 205
211 } // namespace content 206 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698