Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3039)

Unified Diff: build_overrides/v8.gni

Issue 1962343002: [headless] Use embedded v8 data for headless. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment added Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/args/headless.gn ('K') | « build/args/headless.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_overrides/v8.gni
diff --git a/build_overrides/v8.gni b/build_overrides/v8.gni
index c39f47e3b00f082971a63e8488e3466a447c436b..f5330cf6e4ce0c907a3f59f5311d674567fc39e0 100644
--- a/build_overrides/v8.gni
+++ b/build_overrides/v8.gni
@@ -2,6 +2,10 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+declare_args() {
+ v8_use_external_startup_data = !is_ios
+}
+
if (is_android) {
import("//build/config/android/config.gni")
}
@@ -9,8 +13,6 @@ if (is_android) {
# TODO(sky): nuke this. Temporary while sorting out http://crbug.com/465456.
enable_correct_v8_arch = false
-v8_use_external_startup_data = !is_ios
-
# Turns on compiler optimizations in V8 in Debug build.
v8_optimized_debug = true
« build/args/headless.gn ('K') | « build/args/headless.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698