Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 1962333002: [ios] Do not lock schemes registry in WebTest. (Closed)

Created:
4 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Do not lock schemes registry in WebTest. WebTest is a videly used test fixture and it should not lock schemes and allow other tests to register own schemes. BUG=610619 Committed: https://crrev.com/044bdfa06dfe1480fa26c6cb178af13f38bd2a3f Cr-Commit-Position: refs/heads/master@{#392937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/web/test/web_test.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Eugene But (OOO till 7-30)
After landing this I will unwind changes made here: https://chromereviews.googleplex.com/423787013/patch/60001/70002 And then will move Schemes ...
4 years, 7 months ago (2016-05-10 17:19:29 UTC) #2
sdefresne
lgtm
4 years, 7 months ago (2016-05-11 08:50:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962333002/1
4 years, 7 months ago (2016-05-11 15:23:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 16:01:49 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 16:04:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/044bdfa06dfe1480fa26c6cb178af13f38bd2a3f
Cr-Commit-Position: refs/heads/master@{#392937}

Powered by Google App Engine
This is Rietveld 408576698