Source/core/page/DOMWindow.cpp - Issue 19623002: Make atob() throw an InvalidCharacterError on excess padding characters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DOMWindow.cpp

Issue 19623002: Make atob() throw an InvalidCharacterError on excess padding characters (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/DOMWindow.cpp

diff --git a/Source/core/page/DOMWindow.cpp b/Source/core/page/DOMWindow.cpp

index b4547b122f8ac1f06b38b9e5b893b02870e67781..74f497a791ffc00265fed83d42fa64bfc3688fc9 100644

--- a/Source/core/page/DOMWindow.cpp

+++ b/Source/core/page/DOMWindow.cpp

@@ -967,7 +967,7 @@ String DOMWindow::atob(const String& encodedString, ExceptionCode& ec)

}

Vector<char> out;

- if (!base64Decode(encodedString, out, Base64FailOnInvalidCharacter)) {

+ if (!base64Decode(encodedString, out, Base64FailOnInvalidCharacter, Base64StrictPaddingValidation)) {

ec = InvalidCharacterError;

return String();

}