Make atob() throw an InvalidCharacterError on excess padding characters

Make atob() throw an InvalidCharacterError on excess padding characters

According to the latest specification, window.atob() should throw an
InvalidCharacterError on excess padding characters:
http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#dom-windowbase64-atob

This behavior is consistent with both Firefox and IE10.

We are now down from 26 failures to 12 on the following test suite:
http://www.w3c-test.org/html/tests/submission/AryehGregor/base64.html

BUG=261200
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154538

[arv (Not doing code reviews), 2013-07-17 17:49:06]

LGTM

https://codereview.chromium.org/19623002/diff/1/LayoutTests/fast/dom/Window/a...
File LayoutTests/fast/dom/Window/atob-btoa-expected.txt (right):

https://codereview.chromium.org/19623002/diff/1/LayoutTests/fast/dom/Window/a...
LayoutTests/fast/dom/Window/atob-btoa-expected.txt:39: PASS window.atob("zzz==")
threw exception InvalidCharacterError: An invalid or illegal character was
specified, such as in an XML name..
This error message is silly.

I'll update it later. https://code.google.com/p/chromium/issues/detail?id=261249

https://codereview.chromium.org/19623002/diff/1/Source/wtf/text/Base64.cpp
File Source/wtf/text/Base64.cpp (right):

https://codereview.chromium.org/19623002/diff/1/Source/wtf/text/Base64.cpp#ne...
Source/wtf/text/Base64.cpp:170: }
} else if (...) {

[commit-bot: I haz the power, 2013-07-18 06:41:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19623002/7001

[commit-bot: I haz the power, 2013-07-18 07:00:37]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[do-not-use, 2013-07-18 07:36:08]

This needs review from a WTF owner because of the changes to Base64.

[eseidel, 2013-07-18 20:51:25]

lgtm

[commit-bot: I haz the power, 2013-07-18 20:51:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19623002/7001

[commit-bot: I haz the power, 2013-07-18 20:51:36]

Failed to apply patch for Source/core/page/DOMWindow.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/page/DOMWindow.cpp
  Hunk #1 FAILED at 967.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/page/DOMWindow.cpp.rej

Patch:       Source/core/page/DOMWindow.cpp
Index: Source/core/page/DOMWindow.cpp
diff --git a/Source/core/page/DOMWindow.cpp b/Source/core/page/DOMWindow.cpp
index
830dc7edd04931cc6887740f27188cbbfbf5da95..c7705d6f5a5dd920e34c963d047cc908355328d4
100644
--- a/Source/core/page/DOMWindow.cpp
+++ b/Source/core/page/DOMWindow.cpp
@@ -967,7 +967,7 @@ String DOMWindow::atob(const String& encodedString,
ExceptionCode& ec)
     }
 
     Vector<char> out;
-    if (!base64Decode(encodedString, out, Base64FailOnInvalidCharacter)) {
+    if (!base64Decode(encodedString, out, Base64FailOnInvalidCharacter,
Base64StrictPaddingValidation)) {
         ec = InvalidCharacterError;
         return String();
     }

[commit-bot: I haz the power, 2013-07-18 20:53:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19623002/20001

[commit-bot: I haz the power, 2013-07-18 20:53:58]

Failed to apply patch for Source/core/page/DOMWindow.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/page/DOMWindow.cpp
  Hunk #1 FAILED at 967.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/page/DOMWindow.cpp.rej

Patch:       Source/core/page/DOMWindow.cpp
Index: Source/core/page/DOMWindow.cpp
diff --git a/Source/core/page/DOMWindow.cpp b/Source/core/page/DOMWindow.cpp
index
830dc7edd04931cc6887740f27188cbbfbf5da95..c7705d6f5a5dd920e34c963d047cc908355328d4
100644
--- a/Source/core/page/DOMWindow.cpp
+++ b/Source/core/page/DOMWindow.cpp
@@ -967,7 +967,7 @@ String DOMWindow::atob(const String& encodedString,
ExceptionCode& ec)
     }
 
     Vector<char> out;
-    if (!base64Decode(encodedString, out, Base64FailOnInvalidCharacter)) {
+    if (!base64Decode(encodedString, out, Base64FailOnInvalidCharacter,
Base64StrictPaddingValidation)) {
         ec = InvalidCharacterError;
         return String();
     }

[commit-bot: I haz the power, 2013-07-18 20:58:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19623002/23001

[commit-bot: I haz the power, 2013-07-18 23:08:35]

Change committed as 154538