Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1962253002: Rename shell to v8_shell (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename shell to v8_shell BUG=chromium:609107 R=machenbach@chromium.org LOG=n Committed: https://crrev.com/35e49f251f1b41703d2eb32fab2fb6044764e822 Cr-Commit-Position: refs/heads/master@{#36138}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M samples/samples.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
jochen (gone - plz use gerrit)
ptal
4 years, 7 months ago (2016-05-10 11:39:08 UTC) #1
Michael Achenbach
lgtm - assuming you'll also update this https://codereview.chromium.org/1953233002/diff/1/BUILD.gn
4 years, 7 months ago (2016-05-10 11:54:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962253002/1
4 years, 7 months ago (2016-05-10 11:55:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14949)
4 years, 7 months ago (2016-05-10 11:57:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962253002/20001
4 years, 7 months ago (2016-05-10 11:59:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 12:30:27 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 12:32:36 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/35e49f251f1b41703d2eb32fab2fb6044764e822
Cr-Commit-Position: refs/heads/master@{#36138}

Powered by Google App Engine
This is Rietveld 408576698