Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: tests/language/pure_function_test.dart

Issue 196223017: Fix bad generate-at-use-site. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/pure_function2_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/pure_function_test.dart
diff --git a/tests/language/pure_function_test.dart b/tests/language/pure_function_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..4bd36bea171ff9f3274aaac9eb679e0dd073c90d
--- /dev/null
+++ b/tests/language/pure_function_test.dart
@@ -0,0 +1,36 @@
+// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import "package:expect/expect.dart";
+
+// Regression test for issue 17483.
+
+class A {
+ var x, y;
+ A(x, this.y) {
+ this.x = x;
+ }
+ toString() => "a";
+}
+
+foo(trace) => trace.add("foo");
+bar(trace) => trace.add("bar");
+
+main() {
+ var trace = [];
+ // Dart2js must keep the order of t1 and t2.
+ var t1 = foo(trace);
+ var t2 = bar(trace);
+ // Dart2js inlines the constructor, yielding something like:
+ // t3 = jsNew A(null, t2); // Note that jsNew is pure.
+ // t3.x = t1;
+ // t3 is used twice and cannot be generated at use site.
+ // Dart2js must not allow t1 to cross the t3-line.
+ var a = new A(t1, t2);
+ // Use a. It is already implicitly used by the this.x = x line in its
+ // constructor. With the following use we use it twice and make sure that
+ // the allocation can not be generated at use-site.
+ trace.add(a.toString());
+ Expect.listEquals(["foo", "bar", "a"], trace);
+}
« no previous file with comments | « tests/language/pure_function2_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698