Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 196223014: Fix running of CSS Animations in SVG-in-<img>/background-image/etc. (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers, Savago
Visibility:
Public.

Description

Fix running of CSS Animations in SVG-in-<img>/background-image/etc. Align SVGImageChromeClient with the WebViewImpl/PageWidgetDelegate/...- cluster and call updateLayoutAndStyleForPainting on FrameView instead of updateLayoutAndStyleIfNeededRecursive to make pending animations start etc. Also add a new method to DocumentTimeline to use when scheduling the animation-timer in SVGImageChromeClient (to avoid '0' timeouts when there's pending animations updates.) BUG=278189 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
A LayoutTests/svg/as-image/resources/css-animation.svg View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-image/svg-image-with-css-animation.html View 1 chunk +12 lines, -0 lines 0 comments Download
A + LayoutTests/svg/as-image/svg-image-with-css-animation-expected.html View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/animation/DocumentTimeline.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
fs
@dstockwell, had to add a method to DocumentTimeline to check if there's any pending animation ...
6 years, 9 months ago (2014-03-14 14:45:30 UTC) #1
pdr.
On 2014/03/14 14:45:30, fs wrote: > @dstockwell, had to add a method to DocumentTimeline to ...
6 years, 9 months ago (2014-03-14 17:20:22 UTC) #2
dstockwell
lgtm
6 years, 9 months ago (2014-03-17 02:20:12 UTC) #3
fs
The CQ bit was checked by fs@opera.com
6 years, 9 months ago (2014-03-17 09:07:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/196223014/1
6 years, 9 months ago (2014-03-17 09:08:01 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-17 11:10:16 UTC) #6
Message was sent while issue was closed.
Change committed as 169340

Powered by Google App Engine
This is Rietveld 408576698