Issue 196223013: check for null-device pixels in onWritePixels, so we don't crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196223013: check for null-device pixels in onWritePixels, so we don't crash (Closed)

Created:
6 years, 9 months ago by reed1

Modified:
6 years, 9 months ago

Reviewers:
hal.canary, bsalomon, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

check for null-device pixels in onWritePixels, so we don't crash https://code.google.com/p/chromium/issues/detail?id=352616 Committed: https://code.google.com/p/skia/source/detail?r=13802

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
	M	gm/stroketext.cpp	View		2 chunks	+16 lines, -0 lines	1 comment	Download
	M	src/core/SkBitmapDevice.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bsalomon

6 years, 9 months ago (2014-03-14 14:03:45 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/196223013/diff/1/gm/stroketext.cpp
File gm/stroketext.cpp (right):

https://codereview.chromium.org/196223013/diff/1/gm/stroketext.cpp#newcode11
gm/stroketext.cpp:11: static void test_nulldev(SkCanvas* canvas) {
should this be in a unit test?

Expand Messages | Collapse Messages