runtime/bin/vmservice/constants.dart - Issue 19622003: VM Service isolate listing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/bin/vmservice/constants.dart

Issue 19622003: VM Service isolate listing (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 library ExtendsTestLib;	5 part of vmservice;

6	6

7 class A {	7 class Constants {

8 var y = "class A from library";	8 static const int isolateStartupMessageId = 1;

	9 static const int isolateShutdownMessageId = 2;
	siva 2013/07/19 17:41:16 Can these just be constants, eg: static const int Can these just be constants, eg: static const int ISOLATE_STARTUP_MESSAGE_ID = 1; The style guide link for naming constants: http://www.dartlang.org/articles/style-guide/#do-name-constants-using-allcaps... Cutch 2013/07/19 18:15:02 Done. Show quoted text On 2013/07/19 17:41:16, siva wrote: > Can these just be constants, eg: > > static const int ISOLATE_STARTUP_MESSAGE_ID = 1; > > > The style guide link for naming constants: > http://www.dartlang.org/articles/style-guide/#do-name-constants-using-allcaps... Done.
9 }	10 }

OLD	NEW