Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1962193002: Add a integration test suite for BlobChannel. (Closed)

Created:
4 years, 7 months ago by Kevin M
Modified:
4 years, 7 months ago
Reviewers:
haibinlu
CC:
chromium-reviews, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a integration test suite for BlobChannel. This test suite exercises the sender and receiver portions of BlobChannel in integration, using a transport-agnostic proxy delegate to connect the two together. Also added: * a string-based overload for CalculateBlobId(); * promoted CreateBlobDataPtr() to a common location. R=haibinlu@chromium.org CC=wez@chromium.org BUG=600719 Committed: https://crrev.com/a62165f3e7ae61c2d8ddd3585aa5d120c8b670aa Cr-Commit-Position: refs/heads/master@{#392648}

Patch Set 1 #

Total comments: 2

Patch Set 2 : haibin comments #

Patch Set 3 : rebase #

Patch Set 4 : remove redundant callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -5 lines) Patch
M blimp/common/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M blimp/common/blob_cache/id_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/common/blob_cache/id_util.cc View 1 chunk +5 lines, -1 line 0 comments Download
A blimp/common/blob_cache/test_util.h View 1 chunk +18 lines, -0 lines 0 comments Download
A + blimp/common/blob_cache/test_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M blimp/net/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A blimp/net/blob_channel/blob_channel_integration_test.cc View 1 2 3 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Kevin M
4 years, 7 months ago (2016-05-09 23:49:07 UTC) #1
haibinlu
lgtm https://codereview.chromium.org/1962193002/diff/1/blimp/net/blob_channel/blob_channel_integration_test.cc File blimp/net/blob_channel/blob_channel_integration_test.cc (right): https://codereview.chromium.org/1962193002/diff/1/blimp/net/blob_channel/blob_channel_integration_test.cc#newcode48 blimp/net/blob_channel/blob_channel_integration_test.cc:48: receiver_->OnBlobReceived(id, data); PostTask to simulate async nature of ...
4 years, 7 months ago (2016-05-10 00:18:38 UTC) #3
Kevin M
https://codereview.chromium.org/1962193002/diff/1/blimp/net/blob_channel/blob_channel_integration_test.cc File blimp/net/blob_channel/blob_channel_integration_test.cc (right): https://codereview.chromium.org/1962193002/diff/1/blimp/net/blob_channel/blob_channel_integration_test.cc#newcode48 blimp/net/blob_channel/blob_channel_integration_test.cc:48: receiver_->OnBlobReceived(id, data); On 2016/05/10 00:18:38, haibinlu wrote: > PostTask ...
4 years, 7 months ago (2016-05-10 00:54:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962193002/40001
4 years, 7 months ago (2016-05-10 00:56:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962193002/60001
4 years, 7 months ago (2016-05-10 17:11:53 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-10 18:17:02 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 18:19:30 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a62165f3e7ae61c2d8ddd3585aa5d120c8b670aa
Cr-Commit-Position: refs/heads/master@{#392648}

Powered by Google App Engine
This is Rietveld 408576698