Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1962163002: Revert of [Chrome Settings UI] If User Exceptions are not allowed, prevent editing / viewing. (Closed)

Created:
4 years, 7 months ago by huangs
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam, Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, grt (UTC plus 2), Georges Khalil, ligimole, manoranjanr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chrome Settings UI] If User Exceptions are not allowed, prevent editing / viewing. (patchset #9 id:160001 of https://chromiumcodereview.appspot.com/1855393006/ ) Reason for revert: Reverting since this is causing http://crbug.com/609725 . Problem is that we're hiding all "non-editable" entries in exception lists. However, the list is sometimes used for read-only data, e.g., Zoom Level. Will need to modify the logic in a follow-up. Original issue's description: > [Chrome Settings UI] If User Exceptions are not allowed, prevent editing / viewing. > > If user exceptions are rendered useless by policy defaults (or other default > providers with higher precedence), disabled them in exceptions dialog by: > - Hiding all editable rows. > - Removing the "Add New Exceptions" row. > > BUG=568031 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/ff30d12673cee058e00d6d8da59ba971f24172bb > Cr-Commit-Position: refs/heads/master@{#391885} TBR=estade@chromium.org,dbeam@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=568031 Committed: https://crrev.com/e6bf538f47aae111b57f425071c48163c1f28795 Cr-Commit-Position: refs/heads/master@{#392453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -87 lines) Patch
M chrome/browser/resources/options/content_settings.js View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/resources/options/content_settings_exceptions_area.js View 4 chunks +2 lines, -43 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 5 chunks +3 lines, -21 lines 0 comments Download
M ui/webui/resources/js/cr/ui/array_data_model.js View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
huangs
Created Revert of [Chrome Settings UI] If User Exceptions are not allowed, prevent editing / ...
4 years, 7 months ago (2016-05-09 21:37:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962163002/1
4 years, 7 months ago (2016-05-09 21:37:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 22:43:46 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 22:46:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6bf538f47aae111b57f425071c48163c1f28795
Cr-Commit-Position: refs/heads/master@{#392453}

Powered by Google App Engine
This is Rietveld 408576698