ui/views/widget/desktop_aura/desktop_native_widget_aura.cc - Issue 196213004: Allows menu host windows to be enumerated in DragTargetWindowFinder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

Issue 196213004: Allows menu host windows to be enumerated in DragTargetWindowFinder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Implements menu XID caching and dispatches mouse drags in a posted task (test) Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc ('K') | « ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc ('k') | ui/views/widget/desktop_aura/x11_desktop_handler.cc » ('j') | ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

diff --git a/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc b/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

index e619661efa63c444714b97c15e8dcfdca1ede312..38339468c2d8909bc7b0018eacb83d38c9ad186c 100644

--- a/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

+++ b/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

@@ -591,6 +591,8 @@ void DesktopNativeWidgetAura::ReorderNativeViews() {

}

void DesktopNativeWidgetAura::ViewRemoved(View* view) {

+ DCHECK(drop_helper_.get() != NULL);

+ drop_helper_->ResetTargetViewIfEquals(view);

sadrul 2014/03/26 18:01:07 Can this have a test?

varkha 2014/03/27 04:48:13 Moved to https://codereview.chromium.org/214083004

}

void DesktopNativeWidgetAura::SetNativeWindowProperty(const char* name,