Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1743)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h

Issue 1962113003: Make ActiveScriptWrappable the GC mixin it is. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h b/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h
index d5804194b83f5cf8f4401829bd718b70c97d6264..74ffa730af6e31d1f74e49a0e899ed9c7b577149 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h
@@ -6,6 +6,7 @@
#define ActiveScriptWrappable_h
#include "core/CoreExport.h"
+#include "platform/heap/Handle.h"
#include "wtf/Noncopyable.h"
namespace blink {
@@ -18,7 +19,7 @@ class ScriptWrappableVisitor;
* thread-specific list. They keep their wrappers and dependant objects alive
* as long as they have pending activity.
*/
-class CORE_EXPORT ActiveScriptWrappable {
+class CORE_EXPORT ActiveScriptWrappable : public GarbageCollectedMixin {
WTF_MAKE_NONCOPYABLE(ActiveScriptWrappable);
public:
explicit ActiveScriptWrappable(ScriptWrappable*);
@@ -29,9 +30,6 @@ public:
ScriptWrappable* toScriptWrappable() const;
-protected:
- virtual ~ActiveScriptWrappable();
-
private:
ScriptWrappable* m_scriptWrappable;
};

Powered by Google App Engine
This is Rietveld 408576698