Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h

Issue 1962113003: Make ActiveScriptWrappable the GC mixin it is. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 // Compute playback rate (k-rate) by incorporating the sample rate 133 // Compute playback rate (k-rate) by incorporating the sample rate
134 // conversion factor, and the value of playbackRate and detune AudioParams. 134 // conversion factor, and the value of playbackRate and detune AudioParams.
135 double computePlaybackRate(); 135 double computePlaybackRate();
136 136
137 // The minimum playbackRate value ever used for this source. 137 // The minimum playbackRate value ever used for this source.
138 double m_minPlaybackRate; 138 double m_minPlaybackRate;
139 }; 139 };
140 140
141 class AudioBufferSourceNode final : public AudioScheduledSourceNode { 141 class AudioBufferSourceNode final : public AudioScheduledSourceNode {
142 DEFINE_WRAPPERTYPEINFO(); 142 DEFINE_WRAPPERTYPEINFO();
143 USING_GARBAGE_COLLECTED_MIXIN(AudioBufferSourceNode);
hongchan 2016/05/10 16:58:28 AudioScheduledSourceNode already has mixin. Is thi
sof 2016/05/10 19:02:01 Thanks for catching that, it is unnecessary as it
143 public: 144 public:
144 static AudioBufferSourceNode* create(AbstractAudioContext&, float sampleRate ); 145 static AudioBufferSourceNode* create(AbstractAudioContext&, float sampleRate );
145 DECLARE_VIRTUAL_TRACE(); 146 DECLARE_VIRTUAL_TRACE();
146 AudioBufferSourceHandler& audioBufferSourceHandler() const; 147 AudioBufferSourceHandler& audioBufferSourceHandler() const;
147 148
148 AudioBuffer* buffer() const; 149 AudioBuffer* buffer() const;
149 void setBuffer(AudioBuffer*, ExceptionState&); 150 void setBuffer(AudioBuffer*, ExceptionState&);
150 AudioParam* playbackRate() const; 151 AudioParam* playbackRate() const;
151 AudioParam* detune() const; 152 AudioParam* detune() const;
152 bool loop() const; 153 bool loop() const;
(...skipping 11 matching lines...) Expand all
164 private: 165 private:
165 AudioBufferSourceNode(AbstractAudioContext&, float sampleRate); 166 AudioBufferSourceNode(AbstractAudioContext&, float sampleRate);
166 167
167 Member<AudioParam> m_playbackRate; 168 Member<AudioParam> m_playbackRate;
168 Member<AudioParam> m_detune; 169 Member<AudioParam> m_detune;
169 }; 170 };
170 171
171 } // namespace blink 172 } // namespace blink
172 173
173 #endif // AudioBufferSourceNode_h 174 #endif // AudioBufferSourceNode_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698