Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1962073003: Fix ASan container overflow in HTMLMenuItemElement::defaultEventHandler (Closed)

Created:
4 years, 7 months ago by pals
Modified:
4 years, 7 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ASan container overflow in HTMLMenuItemElement::defaultEventHandler The root cause is the AtomicString const reference |group|. This reference will be broken after removeAttribute(checkedAttr) is called for the same element. BUG=590619 Committed: https://crrev.com/4189a821a05342bf177d00744175e367dba67868 Cr-Commit-Position: refs/heads/master@{#392584}

Patch Set 1 #

Patch Set 2 : Adding tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/dom/HTMLMenuItemElement/menuitem-crash-asan.html View 1 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/HTMLMenuItemElement/menuitem-crash-asan-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
pals
Please take a look.
4 years, 7 months ago (2016-05-10 05:58:59 UTC) #3
tkent
Please add a test.
4 years, 7 months ago (2016-05-10 06:38:32 UTC) #4
pals
On 2016/05/10 06:38:32, tkent wrote: > Please add a test. Added a test. PTAL.
4 years, 7 months ago (2016-05-10 08:57:10 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962073003/20001
4 years, 7 months ago (2016-05-10 08:57:33 UTC) #7
tkent
lgtm
4 years, 7 months ago (2016-05-10 11:56:11 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-10 12:14:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962073003/20001
4 years, 7 months ago (2016-05-10 12:15:25 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 12:18:41 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 12:19:57 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4189a821a05342bf177d00744175e367dba67868
Cr-Commit-Position: refs/heads/master@{#392584}

Powered by Google App Engine
This is Rietveld 408576698