Desktop Capture Picker New UI: Non Mac Structure Change

Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002.
The reason of unittest crash is that we removed a placeholder
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder
for old picker UI to use.

BUG=602478, 610016
TBR=isherman@chromium.org,rockot@chromium.org

Committed: https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff
Cr-Commit-Position: refs/heads/master@{#392406}

[qiangchen, 2016-05-09 17:08:22]

Description was changed from

==========
Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002

BUG=602478
==========

to

==========
Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002

BUG=602478,610016
==========

[qiangchen, 2016-05-09 17:56:56]

Description was changed from

==========
Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002

BUG=602478,610016
==========

to

==========
Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002. 
The reason of unittest crash is that we removed a placeholder 
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder 
for old picker UI to use.

BUG=602478,610016

TBR=isherman@chromium.org,rockot@chromium.org
==========

[qiangchen, 2016-05-09 17:56:57]

qiangchen@chromium.org changed reviewers:
+ msw@chromium.org

[qiangchen, 2016-05-09 18:01:18]

Sorry for the revert.

After investigation, it is just an overlook of string placeholder. It is an
DCHECK error, and thus hidden in Release mode.

[msw, 2016-05-09 18:05:51]

lgtm

[qiangchen, 2016-05-09 20:04:46]

The CQ bit was checked by qiangchen@chromium.org

[commit-bot: I haz the power, 2016-05-09 20:05:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1962073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1962073002/20001

[commit-bot: I haz the power, 2016-05-09 20:11:43]

Description was changed from

==========
Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002. 
The reason of unittest crash is that we removed a placeholder 
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder 
for old picker UI to use.

BUG=602478,610016

TBR=isherman@chromium.org,rockot@chromium.org
==========

to

==========
Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002. 
The reason of unittest crash is that we removed a placeholder 
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder 
for old picker UI to use.

BUG=602478,610016

TBR=isherman@chromium.org,rockot@chromium.org
==========

[commit-bot: I haz the power, 2016-05-09 20:11:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-09 20:12:47]

Description was changed from

==========
Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002. 
The reason of unittest crash is that we removed a placeholder 
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder 
for old picker UI to use.

BUG=602478,610016

TBR=isherman@chromium.org,rockot@chromium.org
==========

to

==========
Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002.
The reason of unittest crash is that we removed a placeholder
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder
for old picker UI to use.

BUG=602478,610016

TBR=isherman@chromium.org,rockot@chromium.org

Committed: https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff
Cr-Commit-Position: refs/heads/master@{#392406}
==========

[commit-bot: I haz the power, 2016-05-09 20:12:48]

Patchset 2 (id:??) landed as
https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff
Cr-Commit-Position: refs/heads/master@{#392406}