Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: third_party/WebKit/public/platform/WebScheduler.h

Issue 1962053002: Allow expensive task blocking if there is pending iframe navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebScheduler.h
diff --git a/third_party/WebKit/public/platform/WebScheduler.h b/third_party/WebKit/public/platform/WebScheduler.h
index 4d75f1772a17944f018b5b115a8c4d17acc18d43..85ae4674786a4c1f025f9f0db60f8549ab3ccbc3 100644
--- a/third_party/WebKit/public/platform/WebScheduler.h
+++ b/third_party/WebKit/public/platform/WebScheduler.h
@@ -81,10 +81,10 @@ public:
// Tells the scheduler that a navigation task is pending.
// TODO(alexclarke): Long term should this be a task trait?
- virtual void addPendingNavigation() = 0;
+ virtual void addPendingNavigation(bool mainFrameNavigating) = 0;
Sami 2016/05/09 16:45:21 I'm tempted to suggest making this an enum instead
alex clarke (OOO till 29th) 2016/05/09 17:08:09 Yeah I was tempted to do that too, but didn't init
// Tells the scheduler that a navigation task is no longer pending.
- virtual void removePendingNavigation() = 0;
+ virtual void removePendingNavigation(bool mainFrameNavigating) = 0;
// Tells the scheduler that an expected navigation was started.
virtual void onNavigationStarted() = 0;

Powered by Google App Engine
This is Rietveld 408576698