Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: components/search_provider_logos/logo_tracker.h

Issue 1962013002: Adding a parameter that will be used to request a transparent doodle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_provider_logos/logo_tracker.h
diff --git a/components/search_provider_logos/logo_tracker.h b/components/search_provider_logos/logo_tracker.h
index 324d86a07d3e714d801fd16e5ec00b2003479439..7c29e2ece03938763ee62e7a02755a7539aae7e7 100644
--- a/components/search_provider_logos/logo_tracker.h
+++ b/components/search_provider_logos/logo_tracker.h
@@ -79,7 +79,8 @@ typedef base::Callback<std::unique_ptr<EncodedLogo>(
// server to verify whether the cached logo is up-to-date.
typedef base::Callback<GURL(const GURL& logo_url,
const std::string& fingerprint,
- bool wants_cta)> AppendQueryparamsToLogoURL;
+ bool wants_cta,
+ bool transparent)> AppendQueryparamsToLogoURL;
// This class provides the logo for a search provider. Logos are downloaded from
// the search provider's logo URL and cached on disk.
@@ -123,13 +124,15 @@ class LogoTracker : public net::URLFetcherDelegate {
// server's response into a EncodedLogo object. |append_queryparams_func| is a
// callback that will return the URL from which to download the logo.
// |wants_cta| determines if the url should return a call to action image.
+ // |transparent| determines whether to request a transparent logo.
// Note: |parse_logo_response_func| and |append_queryparams_func| must be
// suitable for running multiple times, concurrently, and on multiple threads.
// TODO(ianwen): remove wants_cta from parameter.
void SetServerAPI(const GURL& logo_url,
const ParseLogoResponse& parse_logo_response_func,
const AppendQueryparamsToLogoURL& append_queryparams_func,
- bool wants_cta);
+ bool wants_cta,
+ bool transparent);
// Retrieves the current search provider's logo from the local cache and/or
// over the network, and registers |observer| to be called when the cached
@@ -216,6 +219,9 @@ class LogoTracker : public net::URLFetcherDelegate {
// If |true| request call to action in server API.
bool wants_cta_;
+ // If |true| request transparent doodle.
+ bool transparent_;
+
// False if an asynchronous task is currently running.
bool is_idle_;
« no previous file with comments | « components/search_provider_logos/google_logo_api.cc ('k') | components/search_provider_logos/logo_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698