Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: components/search_provider_logos/logo_tracker_unittest.cc

Issue 1962013002: Adding a parameter that will be used to request a transparent doodle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_provider_logos/logo_tracker_unittest.cc
diff --git a/components/search_provider_logos/logo_tracker_unittest.cc b/components/search_provider_logos/logo_tracker_unittest.cc
index 528cfecc4441405f90535bf53c8db44670d2956a..b96f508d3f3f63aadcb548ebde0f80caa5913df6 100644
--- a/components/search_provider_logos/logo_tracker_unittest.cc
+++ b/components/search_provider_logos/logo_tracker_unittest.cc
@@ -428,6 +428,17 @@ TEST_F(LogoTrackerTest, CTAURLHasComma) {
EXPECT_EQ("http://logourl.com/?a=b&async=cta:1", url_with_fp.spec());
}
+TEST_F(LogoTrackerTest, CTATransparentHasCommas) {
+ GURL url_with_fp = GoogleAppendQueryparamsToLogoURL(
+ GURL("http://logourl.com/path"), "abc123", true, true);
+ EXPECT_EQ("http://logourl.com/path?async=es_dfp:abc123,cta:1,transp:1",
+ url_with_fp.spec());
+
+ url_with_fp = GoogleAppendQueryparamsToLogoURL(
+ GURL("http://logourl.com/?a=b"), "", true, true);
+ EXPECT_EQ("http://logourl.com/?a=b&async=cta:1,transp:1", url_with_fp.spec());
+}
+
TEST_F(LogoTrackerTest, DownloadAndCacheLogo) {
Logo logo = GetSampleLogo(logo_url_, test_clock_->Now());
SetServerResponse(ServerResponse(logo));

Powered by Google App Engine
This is Rietveld 408576698