Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Unified Diff: components/search_provider_logos/google_logo_api.h

Issue 1962013002: Adding a parameter that will be used to request a transparent doodle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_provider_logos/google_logo_api.h
diff --git a/components/search_provider_logos/google_logo_api.h b/components/search_provider_logos/google_logo_api.h
index 09b1e7d321d3b3ed18c6f94538aa7b3743d41aea..1db65a6cee32c1f44d9b6a93e8904be565357905 100644
--- a/components/search_provider_logos/google_logo_api.h
+++ b/components/search_provider_logos/google_logo_api.h
@@ -18,7 +18,8 @@ namespace search_provider_logos {
// doodles.
GURL GoogleAppendQueryparamsToLogoURL(const GURL& logo_url,
const std::string& fingerprint,
- bool wants_cta);
+ bool wants_cta,
+ bool transparent = false);
Marc Treib 2016/05/09 16:58:21 We generally don't use default values for argument
atanasova 2016/05/10 08:32:17 I'll update the code, my only concern is breaking
Marc Treib 2016/05/10 08:48:44 The iOS bots will tell you if anything breaks, and
// Implements ParseLogoResponse, defined in logo_tracker.h, for Google doodles.
std::unique_ptr<EncodedLogo> GoogleParseLogoResponse(

Powered by Google App Engine
This is Rietveld 408576698