Move //courgette/third_party to subfolder.

Move //courgette/third_party to subfolder.

Move //courgette/third_party/ to //courgette/third_party/bsdiff
in order to conform to Chromium style of putting third-party
libraries to named directories.

Also fix some warnings about wrong include order.

R=wfh@chromium.org,huangs@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org

Committed: https://crrev.com/979ea2e1da9e66f1c9101982224f9c0556475df8
Cr-Commit-Position: refs/heads/master@{#394437}

[altimin, 2016-05-10 17:39:18]

Description was changed from

==========
Move //courgette/third_party to subfolder.

Move //courgette/third_party/ to //courgette/third_party/bsdiff
in order to conform to Chromium style of putting third-party
libraries to named directories.

R=wfh@chromium.org,huangs@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
==========

to

==========
Move //courgette/third_party to subfolder.

Move //courgette/third_party/ to //courgette/third_party/bsdiff
in order to conform to Chromium style of putting third-party
libraries to named directories.

Also fix some warnings about wrong include order.

R=wfh@chromium.org,huangs@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
==========

[huangs, 2016-05-10 18:17:03]

Just NITs.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
File courgette/third_party/bsdiff/bsdiff.h (right):

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/bsdiff.h:82: char tag[8];      // Contains
MBS_PATCH_HEADER_TAG
Please also add '.' at end.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
File courgette/third_party/bsdiff/bsdiff_create.cc (right):

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/bsdiff_create.cc:224: old[lastpos + lenf - overlap
+ i])
{ }

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/bsdiff_create.cc:273: "Writing a block:  copy: %-8u
extra: %-8u seek: "
Unwrap and concatenate.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
File courgette/third_party/bsdiff/paged_array.h (right):

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/paged_array.h:9: // contigous arrays.
contiguous

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/paged_array.h:83: }  // namespace
New line before.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
File courgette/third_party/bsdiff/qsufsort.h (right):

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/qsufsort.h:37: // (2) indentation,
... and spacing,

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/qsufsort.h:150: static void qsufsort(T I, T V,
const unsigned char* old, int oldsize) {
Can remove "static".

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/qsufsort.h:198: static int matchlen(const unsigned
char* old,
Remove "static".

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/qsufsort.h:212: static int search(T I,
"static"

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
File courgette/third_party/bsdiff/qsufsort_unittest.cc (right):

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/qsufsort_unittest.cc:19: "",
Is this recommended by formatter?  I'd think 2 spaces would make more sense??

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/qsufsort_unittest.cc:82: // Entire string.
Same here re. spacing.

[altimin, 2016-05-11 17:48:47]

PTAL.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
File courgette/third_party/bsdiff/bsdiff.h (right):

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/bsdiff.h:82: char tag[8];      // Contains
MBS_PATCH_HEADER_TAG
On 2016/05/10 18:17:02, huangs wrote:
> Please also add '.' at end.

Done.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
File courgette/third_party/bsdiff/bsdiff_create.cc (right):

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/bsdiff_create.cc:224: old[lastpos + lenf - overlap
+ i])
On 2016/05/10 18:17:02, huangs wrote:
> { }

Done.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/bsdiff_create.cc:273: "Writing a block:  copy: %-8u
extra: %-8u seek: "
On 2016/05/10 18:17:02, huangs wrote:
> Unwrap and concatenate.

Done.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
File courgette/third_party/bsdiff/paged_array.h (right):

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/paged_array.h:9: // contigous arrays.
On 2016/05/10 18:17:02, huangs wrote:
> contiguous

Done.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/paged_array.h:83: }  // namespace
On 2016/05/10 18:17:02, huangs wrote:
> New line before.

Done.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
File courgette/third_party/bsdiff/qsufsort.h (right):

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/qsufsort.h:37: // (2) indentation,
On 2016/05/10 18:17:03, huangs wrote:
> ... and spacing,

Done.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/qsufsort.h:150: static void qsufsort(T I, T V,
const unsigned char* old, int oldsize) {
On 2016/05/10 18:17:03, huangs wrote:
> Can remove "static".

Done.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/qsufsort.h:150: static void qsufsort(T I, T V,
const unsigned char* old, int oldsize) {
On 2016/05/10 18:17:03, huangs wrote:
> Can remove "static".

Done.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/qsufsort.h:212: static int search(T I,
On 2016/05/10 18:17:03, huangs wrote:
> "static"

Done.

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
File courgette/third_party/bsdiff/qsufsort_unittest.cc (right):

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/qsufsort_unittest.cc:19: "",
On 2016/05/10 18:17:03, huangs wrote:
> Is this recommended by formatter?  I'd think 2 spaces would make more sense??

I've just run "git cl format" :)

https://codereview.chromium.org/1961963003/diff/20001/courgette/third_party/b...
courgette/third_party/bsdiff/qsufsort_unittest.cc:82: // Entire string.
On 2016/05/10 18:17:03, huangs wrote:
> Same here re. spacing.

I'm not a big fan of deviating from what "git cl format" recommends.

[huangs, 2016-05-13 03:56:47]

Sorry for the slowness; forgot to check earlier today.

PTAL with NITS.

https://chromiumcodereview.appspot.com/1961963003/diff/60001/courgette/third_...
File courgette/third_party/bsdiff/README.chromium (right):

https://chromiumcodereview.appspot.com/1961963003/diff/60001/courgette/third_...
courgette/third_party/bsdiff/README.chromium:15: Colin Percival, Naive
differences of executable code, http://www.daemonology.net/bsdiff/, 200
", 2003."

https://chromiumcodereview.appspot.com/1961963003/diff/60001/courgette/third_...
File courgette/third_party/bsdiff/bsdiff.h (right):

https://chromiumcodereview.appspot.com/1961963003/diff/60001/courgette/third_...
courgette/third_party/bsdiff/bsdiff.h:37: #ifndef COURGETTE_BSDIFF_H_
Should these be modified? I don't know what the convention is though.

https://chromiumcodereview.appspot.com/1961963003/diff/60001/courgette/third_...
File courgette/third_party/bsdiff/paged_array.h (right):

https://chromiumcodereview.appspot.com/1961963003/diff/60001/courgette/third_...
courgette/third_party/bsdiff/paged_array.h:11: #ifndef
COURGETTE_BSDIFF_PAGED_ARRAY_H_
Should these be modified? I don't know what the convention is though.

https://chromiumcodereview.appspot.com/1961963003/diff/60001/courgette/third_...
courgette/third_party/bsdiff/paged_array.h:84: }  // namespace
NIT:
// namespace courgette

https://chromiumcodereview.appspot.com/1961963003/diff/60001/courgette/third_...
File courgette/third_party/bsdiff/qsufsort.h (right):

https://chromiumcodereview.appspot.com/1961963003/diff/60001/courgette/third_...
courgette/third_party/bsdiff/qsufsort.h:25: 
Please add

#ifdef ???
#define ???
...
#endif  // ???

My fault for forgetting that in the first place.  Thanks!

[altimin, 2016-05-13 13:16:57]

PTAL.

https://codereview.chromium.org/1961963003/diff/60001/courgette/third_party/b...
File courgette/third_party/bsdiff/README.chromium (right):

https://codereview.chromium.org/1961963003/diff/60001/courgette/third_party/b...
courgette/third_party/bsdiff/README.chromium:15: Colin Percival, Naive
differences of executable code, http://www.daemonology.net/bsdiff/, 200
On 2016/05/13 03:56:47, huangs wrote:
> ", 2003."

Done.

https://codereview.chromium.org/1961963003/diff/60001/courgette/third_party/b...
File courgette/third_party/bsdiff/bsdiff.h (right):

https://codereview.chromium.org/1961963003/diff/60001/courgette/third_party/b...
courgette/third_party/bsdiff/bsdiff.h:37: #ifndef COURGETTE_BSDIFF_H_
On 2016/05/13 03:56:47, huangs wrote:
> Should these be modified? I don't know what the convention is though.

I should have noticed that, sorry.
Done.

https://codereview.chromium.org/1961963003/diff/60001/courgette/third_party/b...
File courgette/third_party/bsdiff/paged_array.h (right):

https://codereview.chromium.org/1961963003/diff/60001/courgette/third_party/b...
courgette/third_party/bsdiff/paged_array.h:11: #ifndef
COURGETTE_BSDIFF_PAGED_ARRAY_H_
On 2016/05/13 03:56:47, huangs wrote:
> Should these be modified? I don't know what the convention is though.

Done.

https://codereview.chromium.org/1961963003/diff/60001/courgette/third_party/b...
courgette/third_party/bsdiff/paged_array.h:84: }  // namespace
On 2016/05/13 03:56:47, huangs wrote:
> NIT:
> // namespace courgette

Done.

https://codereview.chromium.org/1961963003/diff/60001/courgette/third_party/b...
File courgette/third_party/bsdiff/qsufsort.h (right):

https://codereview.chromium.org/1961963003/diff/60001/courgette/third_party/b...
courgette/third_party/bsdiff/qsufsort.h:25: 
On 2016/05/13 03:56:47, huangs wrote:
> Please add
> 
> #ifdef ???
> #define ???
> ...
> #endif  // ???
> 
> My fault for forgetting that in the first place.  Thanks!

Done.

[huangs, 2016-05-13 16:58:41]

LGTM. Thanks!

[huangs, 2016-05-13 17:56:47]

huangs@chromium.org changed reviewers:
+ cpu@chromium.org

[huangs, 2016-05-13 17:57:25]

huangs@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[huangs, 2016-05-13 17:58:51]

+cpu@ for OWNER review for:
  chrome/browser/component_updater/component_patcher_operation_out_of_process.cc
  chrome/installer/setup/setup_util.h
  chrome/installer/setup/setup_util.cc
  chrome/utility/chrome_content_utility_client.cc
  components/update_client/component_patcher_operation.cc
  components/update_client/component_patcher_unittest.h
  components/update_client/component_patcher_unittest.cc

+phajdan.jr@ for OWNER review for
  tools/checklicenses/checklicenses.py

PTAL.

[Paweł Hajdan Jr., 2016-05-16 09:58:53]

LGTM

[cpu_(ooo_6.6-7.5), 2016-05-18 14:39:37]

lgtm

[altimin, 2016-05-18 14:43:15]

The CQ bit was checked by altimin@chromium.org

[commit-bot: I haz the power, 2016-05-18 14:43:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961963003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961963003/80001

[commit-bot: I haz the power, 2016-05-18 16:16:34]

Description was changed from

==========
Move //courgette/third_party to subfolder.

Move //courgette/third_party/ to //courgette/third_party/bsdiff
in order to conform to Chromium style of putting third-party
libraries to named directories.

Also fix some warnings about wrong include order.

R=wfh@chromium.org,huangs@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
==========

to

==========
Move //courgette/third_party to subfolder.

Move //courgette/third_party/ to //courgette/third_party/bsdiff
in order to conform to Chromium style of putting third-party
libraries to named directories.

Also fix some warnings about wrong include order.

R=wfh@chromium.org,huangs@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
==========

[commit-bot: I haz the power, 2016-05-18 16:16:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-18 16:18:14]

Description was changed from

==========
Move //courgette/third_party to subfolder.

Move //courgette/third_party/ to //courgette/third_party/bsdiff
in order to conform to Chromium style of putting third-party
libraries to named directories.

Also fix some warnings about wrong include order.

R=wfh@chromium.org,huangs@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
==========

to

==========
Move //courgette/third_party to subfolder.

Move //courgette/third_party/ to //courgette/third_party/bsdiff
in order to conform to Chromium style of putting third-party
libraries to named directories.

Also fix some warnings about wrong include order.

R=wfh@chromium.org,huangs@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org

Committed: https://crrev.com/979ea2e1da9e66f1c9101982224f9c0556475df8
Cr-Commit-Position: refs/heads/master@{#394437}
==========

[commit-bot: I haz the power, 2016-05-18 16:18:15]

Patchset 5 (id:??) landed as
https://crrev.com/979ea2e1da9e66f1c9101982224f9c0556475df8
Cr-Commit-Position: refs/heads/master@{#394437}