[debugger] make strict eval-scope visible to debugging.

[debugger] make strict eval-scope visible to debugging.

R=jgruber@chromium.org,kozyatinskiy@chromium.org
BUG=chromium:590256
LOG=N

Committed: https://crrev.com/506999c30605912fe2c2b95634dc176b139b1456
Cr-Commit-Position: refs/heads/master@{#36195}

[jgruber1, 2016-05-11 08:38:06]

jgruber@google.com changed reviewers:
+ jgruber@google.com

[jgruber1, 2016-05-11 08:38:07]

lgtm

https://codereview.chromium.org/1961963002/diff/1/src/debug/debug-scopes.cc
File src/debug/debug-scopes.cc (right):

https://codereview.chromium.org/1961963002/diff/1/src/debug/debug-scopes.cc#n...
src/debug/debug-scopes.cc:236: return ScopeTypeEval;
Should we add a default clause here or alternatively add UNREACHABLE() after the
switch?

https://codereview.chromium.org/1961963002/diff/1/src/debug/mirrors.js
File src/debug/mirrors.js (right):

https://codereview.chromium.org/1961963002/diff/1/src/debug/mirrors.js#newcod...
src/debug/mirrors.js:265: Eval:    6,
I assume there's a reason to disregard the comment above?

[Yang, 2016-05-11 11:37:11]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-05-11 11:37:12]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@google.com
Link to the patchset: https://codereview.chromium.org/1961963002/#ps20001
(title: "addressed comments and added fixes to tests")

[commit-bot: I haz the power, 2016-05-11 11:37:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961963002/20001

[Yang, 2016-05-11 11:37:23]

https://codereview.chromium.org/1961963002/diff/1/src/debug/debug-scopes.cc
File src/debug/debug-scopes.cc (right):

https://codereview.chromium.org/1961963002/diff/1/src/debug/debug-scopes.cc#n...
src/debug/debug-scopes.cc:236: return ScopeTypeEval;
On 2016/05/11 08:38:06, jgruber wrote:
> Should we add a default clause here or alternatively add UNREACHABLE() after
the
> switch?

The compiler would fail if the switch does not list all the enum cases and does
not have a default. I added an UNREACHABLE though.

https://codereview.chromium.org/1961963002/diff/1/src/debug/mirrors.js
File src/debug/mirrors.js (right):

https://codereview.chromium.org/1961963002/diff/1/src/debug/mirrors.js#newcod...
src/debug/mirrors.js:265: Eval:    6,
On 2016/05/11 08:38:07, jgruber wrote:
> I assume there's a reason to disregard the comment above?

Good point. I'm fairly certain that devtools does not use magic numbers, but
let's not rely on it.

[commit-bot: I haz the power, 2016-05-11 11:53:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 11:53:53]

Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Yang, 2016-05-12 05:58:10]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-05-12 05:58:11]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@google.com
Link to the patchset: https://codereview.chromium.org/1961963002/#ps40001
(title: "prevent optimization")

[commit-bot: I haz the power, 2016-05-12 05:58:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 05:58:20]

This CL has an open dependency (Issue 1968263002 Patch 60001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Yang, 2016-05-12 06:25:36]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-05-12 06:25:37]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@google.com
Link to the patchset: https://codereview.chromium.org/1961963002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-12 06:25:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961963002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961963002/60001

[commit-bot: I haz the power, 2016-05-12 06:55:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-12 06:57:18]

Description was changed from

==========
[debugger] make strict eval-scope visible to debugging.


R=jgruber@chromium.org,kozyatinskiy@chromium.org
BUG=chromium:590256
LOG=N
==========

to

==========
[debugger] make strict eval-scope visible to debugging.

R=jgruber@chromium.org,kozyatinskiy@chromium.org
BUG=chromium:590256
LOG=N

Committed: https://crrev.com/506999c30605912fe2c2b95634dc176b139b1456
Cr-Commit-Position: refs/heads/master@{#36195}
==========

[commit-bot: I haz the power, 2016-05-12 06:57:19]

Patchset 4 (id:??) landed as
https://crrev.com/506999c30605912fe2c2b95634dc176b139b1456
Cr-Commit-Position: refs/heads/master@{#36195}