DBC: Adds DecodeLoadObjectFromPoolOrThread, enables tests

DBC: Adds DecodeLoadObjectFromPoolOrThread, enables tests

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/a6c686234c7a0ca4eadb63200df83fba6ded4c96

[zra, 2016-05-09 17:46:38]

zra@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2016-05-09 18:26:13]

lgtm

https://codereview.chromium.org/1961953003/diff/1/runtime/vm/instructions_dbc.cc
File runtime/vm/instructions_dbc.cc (right):

https://codereview.chromium.org/1961953003/diff/1/runtime/vm/instructions_dbc...
runtime/vm/instructions_dbc.cc:118: (Bytecode::DecodeOpcode(instr) ==
Bytecode::kLoadConstant)) {
There are more instructions that load stuff from pool:

StaticCall and InstanceCall* also load stuff from pool 

StoreStaticTOS, PushStatic load field from PP

Allocate D loads class from PP

InstantiateType, InstantiateTypeArgumentsTOS, AssertAssignable. 

I am not sure if this is important for the observatory use case or not. 

At least InstanceCall* might be important because they load ICData.

[zra, 2016-05-09 19:36:11]

https://codereview.chromium.org/1961953003/diff/1/runtime/vm/instructions_dbc.cc
File runtime/vm/instructions_dbc.cc (right):

https://codereview.chromium.org/1961953003/diff/1/runtime/vm/instructions_dbc...
runtime/vm/instructions_dbc.cc:118: (Bytecode::DecodeOpcode(instr) ==
Bytecode::kLoadConstant)) {
On 2016/05/09 18:26:13, Vyacheslav Egorov (Google) wrote:
> There are more instructions that load stuff from pool:
> 
> StaticCall and InstanceCall* also load stuff from pool 
> 
> StoreStaticTOS, PushStatic load field from PP
> 
> Allocate D loads class from PP
> 
> InstantiateType, InstantiateTypeArgumentsTOS, AssertAssignable. 
> 
> I am not sure if this is important for the observatory use case or not. 
> 
> At least InstanceCall* might be important because they load ICData.

Ah, yah, it looks like lots of these have potentially useful information, so
I've just included all of them.

[zra, 2016-05-09 19:52:38]

Description was changed from

==========
DBC: Adds DecodeLoadObjectFromPoolOrThread, enables tests
==========

to

==========
DBC: Adds DecodeLoadObjectFromPoolOrThread, enables tests

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a6c686234c7a0ca4eadb63200df83fba6ded4c96
==========

[zra, 2016-05-09 19:52:40]

Committed patchset #2 (id:20001) manually as
a6c686234c7a0ca4eadb63200df83fba6ded4c96 (presubmit successful).