Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1961943004: Have the Notification Id Generator produce readable results (Closed)

Created:
4 years, 7 months ago by Peter Beverloo
Modified:
4 years, 7 months ago
CC:
chromium-reviews, Peter Beverloo, darin-cc_chromium.org, mlamouri+watch-notifications_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have the Notification Id Generator produce readable results Previously it included some binary values that could not always be cleanly presented. The length of a generated Id will be ~70 characters. BUG= Committed: https://crrev.com/d07b5c45b92aa392fc61be91307b5153b63ac1bf Cr-Commit-Position: refs/heads/master@{#392654}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M content/browser/notifications/notification_id_generator.cc View 1 4 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Peter Beverloo
+mvanouwerkerk, this ticks off the ID Generator bits of the larger Mojo CL
4 years, 7 months ago (2016-05-10 15:31:43 UTC) #2
Michael van Ouwerkerk
lgtm with nit https://codereview.chromium.org/1961943004/diff/1/content/browser/notifications/notification_id_generator.cc File content/browser/notifications/notification_id_generator.cc (right): https://codereview.chromium.org/1961943004/diff/1/content/browser/notifications/notification_id_generator.cc#newcode81 content/browser/notifications/notification_id_generator.cc:81: stream << base::IntToString(tag.size() ? 1 : ...
4 years, 7 months ago (2016-05-10 16:57:15 UTC) #3
Peter Beverloo
Done, thanks!
4 years, 7 months ago (2016-05-10 17:03:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961943004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961943004/20001
4 years, 7 months ago (2016-05-10 17:04:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 18:23:10 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 18:25:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d07b5c45b92aa392fc61be91307b5153b63ac1bf
Cr-Commit-Position: refs/heads/master@{#392654}

Powered by Google App Engine
This is Rietveld 408576698