LayoutTests/svg/custom/svg-getelementid.xhtml - Issue 196193003: Revert "Simplify SVGSVGElement::getElementById method"

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/custom/svg-getelementid.xhtml

Issue 196193003: Revert "Simplify SVGSVGElement::getElementById method" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html xmlns="http://www.w3.org/1999/xhtml">	1 <html xmlns="http://www.w3.org/1999/xhtml">

2 <head>	2 <head>

3 <script src="../../resources/js-test.js"/>	3 <script src="../../resources/js-test.js"/>

4 </head>	4 </head>

5 <body>	5 <body>

6	6

7 <div id="console"/>	7 <div id="console"/>

8	8

9 <div id="foo"/>	9 <div id="foo"/>

10 <div id="bar"/>	10 <div id="bar"/>

(...skipping 61 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
72 var bar = root.getElementById("bar");	72 var bar = root.getElementById("bar");

73 shouldBeTrue("svgTree5.firstChild.nextSibling == bar");	73 shouldBeTrue("svgTree5.firstChild.nextSibling == bar");

74	74

75 // Test that search in svg subtree returns the first of the duplicates	75 // Test that search in svg subtree returns the first of the duplicates

76 shouldBeTrue("svgTree5.firstChild.nextSibling == svgTree5.getElementById('bar' )");	76 shouldBeTrue("svgTree5.firstChild.nextSibling == svgTree5.getElementById('bar' )");

77	77

78 // Test that non SVG content can be found in the svg subtree	78 // Test that non SVG content can be found in the svg subtree

79 var nonsvg = root.getElementById("nonsvg");	79 var nonsvg = root.getElementById("nonsvg");

80 var foreign = root.getElementById("foreign");	80 var foreign = root.getElementById("foreign");

81 shouldBeTrue("foreign.firstChild.nextSibling == nonsvg");	81 shouldBeTrue("foreign.firstChild.nextSibling == nonsvg");

	82

	83 // Test that SVG element can find child elements when svg is not part of docum ent yet

	84 var orphanSvg = document.createElementNS('http://www.w3.org/2000/svg', 'svg');

	85 var childSvg = document.createElementNS('http://www.w3.org/2000/svg', 'g');

	86 orphanSvg.appendChild(childSvg)

	87 childSvg.id = 'fooSvg2'

	88 shouldBeTrue("childSvg == orphanSvg.getElementById('fooSvg2')");

82 ]]></script>	89 ]]></script>

83	90

84 </body>	91 </body>

85 </html>	92 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/custom/svg-getelementid-expected.txt » ('j') | Source/core/svg/SVGSVGElement.cpp » ('J')