third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py - Issue 1961883002: Generate separate files for union type containers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

Issue 1961883002: Generate separate files for union type containers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py ('k') | third_party/WebKit/Source/bindings/scripts/utilities.py » ('j') | third_party/WebKit/Source/bindings/scripts/utilities.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

diff --git a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

index 3e4270294ebbaf3c9ceb30a64099d596e4263c5a..2434a82048656de5c5877534580174f28fac14d6 100755

--- a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

+++ b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

@@ -287,9 +287,11 @@ def compute_interfaces_info_overall(info_individuals):

else:

dependencies_other_component_include_paths.append(include_path)

- if interface_info['has_union_types']:

+ for union_type in interface_info.get('union_types', []):

+ if union_type.is_nullable:

+ union_type = union_type.inner_type

dependencies_include_paths.append(

- 'bindings/%s/v8/UnionTypes%s.h' % (component, component.capitalize()))

+ 'bindings/%s/v8/%s.h' % (component, union_type.name))

interface_info.update({

'dependencies_full_paths': dependencies_full_paths,

@@ -303,7 +305,7 @@ def compute_interfaces_info_overall(info_individuals):

# Clean up temporary private information

for interface_info in interfaces_info.itervalues():

del interface_info['extended_attributes']

- del interface_info['has_union_types']

+ del interface_info['union_types']

del interface_info['is_legacy_treat_as_partial_interface']

# Compute global_type_info to interfaces_info so that idl_compiler does