tools: Fix a syntax error in plot-timer-events

tools: Fix a syntax error in plot-timer-events

This fixes a syntax error in plot-timer-events script.

Before:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  tools/plot-timer-events: 75: tools/plot-timer-events: options+=1343: not found
  --distortion=
  Cmdline args: [options] [log-file-name]
  Default log file name is "v8.log".
    ...

After:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  $ ls timer-events.png
  timer-events.png

BUG=

Committed: https://crrev.com/726d3be8ae7a21b04d5144363988d387ad7f2db9
Cr-Commit-Position: refs/heads/master@{#36434}

[Honggyu Kim, 2016-05-09 10:16:54]

Description was changed from

==========
tools: Fix a syntax error in plot-timer-events

This fixes a syntax error in plot-timer-events script.

Before:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  tools/plot-timer-events: 75: tools/plot-timer-events: options+=1343: not found
  --distortion=
  Cmdline args: [options] [log-file-name]
  Default log file name is "v8.log".
    ...

After:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  $ ls timer-events.png
  timer-events.png

BUG=
==========

to

==========
tools: Fix a syntax error in plot-timer-events

This fixes a syntax error in plot-timer-events script.

Before:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  tools/plot-timer-events: 75: tools/plot-timer-events: options+=1343: not found
  --distortion=
  Cmdline args: [options] [log-file-name]
  Default log file name is "v8.log".
    ...

After:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  $ ls timer-events.png
  timer-events.png

BUG=
==========

[Honggyu Kim, 2016-05-09 10:16:54]

nexus226@gmail.com changed reviewers:
+ machenbach@chromium.org, yangguo@chromium.org

[Honggyu Kim, 2016-05-18 07:03:25]

On 2016/05/09 10:16:54, Honggyu Kim wrote:
> mailto:nexus226@gmail.com changed reviewers:
> + mailto:machenbach@chromium.org, mailto:yangguo@chromium.org

Hi,

I'm just wondering if no one uses this script now but I found that current
'plot-timer-events' script doesn't work due to syntax error.
It may not be a critical issue but can you please check this?

Thanks,
Honggyu

[Yang, 2016-05-23 08:07:54]

On 2016/05/18 07:03:25, Honggyu Kim wrote:
> On 2016/05/09 10:16:54, Honggyu Kim wrote:
> > mailto:nexus226@gmail.com changed reviewers:
> > + mailto:machenbach@chromium.org, mailto:yangguo@chromium.org
> 
> Hi,
> 
> I'm just wondering if no one uses this script now but I found that current
> 'plot-timer-events' script doesn't work due to syntax error.
> It may not be a critical issue but can you please check this?
> 
> Thanks,
> Honggyu

The current version works for me on bash. Maybe you are using a different shell?
Anyhow, LGTM.

[Yang, 2016-05-23 08:07:57]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-05-23 08:08:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961873002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961873002/1

[commit-bot: I haz the power, 2016-05-23 08:11:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 08:11:31]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15725)

[Yang, 2016-05-23 08:12:23]

On 2016/05/23 08:11:31, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_presubmit on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15725)

hm... Honggyu, could you add yourself to the AUTHORS file? Thanks.

[Honggyu Kim, 2016-05-23 08:30:12]

On 2016/05/23 08:12:23, Yang wrote:
> hm... Honggyu, could you add yourself to the AUTHORS file? Thanks.

Okay. I will do that right now. But the problem is that it's written to use
/bin/sh instead of bash.
I will submit a new patchset very soon.
Thanks for the review!

[Honggyu Kim, 2016-05-23 08:57:04]

On 2016/05/23 08:30:12, Honggyu Kim wrote:
> I will submit a new patchset very soon.

I'm sorry but can you please let me know how to submit a patchset?
I just did 'git cl upload' but it did create a new issue. (so deleted it)

I cannot find the exact guide for it.
https://www.chromium.org/developers/contributing-code

Thanks,
Honggyu

[Yang, 2016-05-23 09:20:37]

On 2016/05/23 08:57:04, Honggyu Kim wrote:
> On 2016/05/23 08:30:12, Honggyu Kim wrote:
> > I will submit a new patchset very soon.
> 
> I'm sorry but can you please let me know how to submit a patchset?
> I just did 'git cl upload' but it did create a new issue. (so deleted it)
> 
> I cannot find the exact guide for it.
> https://www.chromium.org/developers/contributing-code
> 
> Thanks,
> Honggyu

You can check out this CL by 'git cl patch <issue number>'. You can then use
'git cl issue' to check which CL is associated with the branch. You can then use
'git cl upload' to upload a new patchset.

[Honggyu Kim, 2016-05-23 09:47:15]

On 2016/05/23 09:20:37, Yang wrote:
> You can check out this CL by 'git cl patch <issue number>'. You can then use
> 'git cl issue' to check which CL is associated with the branch. You can then
use
> 'git cl upload' to upload a new patchset.

Just uploaded a new patchset.  I appreciate your explanation.

Thanks,
Honggyu

[Yang, 2016-05-23 09:47:55]

On 2016/05/23 09:47:15, Honggyu Kim wrote:
> On 2016/05/23 09:20:37, Yang wrote:
> > You can check out this CL by 'git cl patch <issue number>'. You can then use
> > 'git cl issue' to check which CL is associated with the branch. You can then
> use
> > 'git cl upload' to upload a new patchset.
> 
> Just uploaded a new patchset.  I appreciate your explanation.
> 
> Thanks,
> Honggyu

LGTM. Thanks!

[Yang, 2016-05-23 09:47:59]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-05-23 09:48:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961873002/20001

[commit-bot: I haz the power, 2016-05-23 10:18:10]

Description was changed from

==========
tools: Fix a syntax error in plot-timer-events

This fixes a syntax error in plot-timer-events script.

Before:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  tools/plot-timer-events: 75: tools/plot-timer-events: options+=1343: not found
  --distortion=
  Cmdline args: [options] [log-file-name]
  Default log file name is "v8.log".
    ...

After:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  $ ls timer-events.png
  timer-events.png

BUG=
==========

to

==========
tools: Fix a syntax error in plot-timer-events

This fixes a syntax error in plot-timer-events script.

Before:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  tools/plot-timer-events: 75: tools/plot-timer-events: options+=1343: not found
  --distortion=
  Cmdline args: [options] [log-file-name]
  Default log file name is "v8.log".
    ...

After:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  $ ls timer-events.png
  timer-events.png

BUG=
==========

[commit-bot: I haz the power, 2016-05-23 10:18:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-23 10:19:51]

Description was changed from

==========
tools: Fix a syntax error in plot-timer-events

This fixes a syntax error in plot-timer-events script.

Before:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  tools/plot-timer-events: 75: tools/plot-timer-events: options+=1343: not found
  --distortion=
  Cmdline args: [options] [log-file-name]
  Default log file name is "v8.log".
    ...

After:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  $ ls timer-events.png
  timer-events.png

BUG=
==========

to

==========
tools: Fix a syntax error in plot-timer-events

This fixes a syntax error in plot-timer-events script.

Before:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  tools/plot-timer-events: 75: tools/plot-timer-events: options+=1343: not found
  --distortion=
  Cmdline args: [options] [log-file-name]
  Default log file name is "v8.log".
    ...

After:
  $ out/x64.release/d8 --prof --log-timer-events script.js
  $ tools/plot-timer-events v8.log
  $ ls timer-events.png
  timer-events.png

BUG=

Committed: https://crrev.com/726d3be8ae7a21b04d5144363988d387ad7f2db9
Cr-Commit-Position: refs/heads/master@{#36434}
==========

[commit-bot: I haz the power, 2016-05-23 10:19:52]

Patchset 2 (id:??) landed as
https://crrev.com/726d3be8ae7a21b04d5144363988d387ad7f2db9
Cr-Commit-Position: refs/heads/master@{#36434}