[wasm] Verify expressions do not cross control boundaries in WASM.

[wasm] Verify expressions do not cross control boundaries in WASM.

This catches malformed code like the following example:

<expr>
<block begin>
<expr>
<binop>
<end>

Which is illegal because the inputs to the binop cross the block boundary.

R=rossberg@chromium.org,ahaas@chromium.org
BUG=

Committed: https://crrev.com/73a988a0d5b24231127eee9019296040e0cefd80
Cr-Commit-Position: refs/heads/master@{#36103}

[ahaas, 2016-05-09 09:55:43]

lgtm

Haha, at first I forgot that I have to read the wasm code in post order now ;-)

https://codereview.chromium.org/1961853002/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/1961853002/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1160: size_t limit = control_.empty() ? 0 :
control_.back().stack_depth;
Could you add a comment at the declaration of control_ which describes what
control_ is?

[titzer, 2016-05-09 09:57:20]

https://codereview.chromium.org/1961853002/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/1961853002/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1160: size_t limit = control_.empty() ? 0 :
control_.back().stack_depth;
On 2016/05/09 09:55:43, ahaas wrote:
> Could you add a comment at the declaration of control_ which describes what
> control_ is?

Done.

[titzer, 2016-05-09 10:32:34]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-05-09 10:32:35]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/1961853002/#ps20001
(title: "Add comment")

[commit-bot: I haz the power, 2016-05-09 10:32:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961853002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961853002/20001

[commit-bot: I haz the power, 2016-05-09 10:34:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-09 10:36:30]

Description was changed from

==========
[wasm] Verify expressions do not cross control boundaries in WASM.

This catches malformed code like the following example:

<expr>
<block begin>
<expr>
<binop>
<end>

Which is illegal because the inputs to the binop cross the block boundary.

R=rossberg@chromium.org,ahaas@chromium.org
BUG=
==========

to

==========
[wasm] Verify expressions do not cross control boundaries in WASM.

This catches malformed code like the following example:

<expr>
<block begin>
<expr>
<binop>
<end>

Which is illegal because the inputs to the binop cross the block boundary.

R=rossberg@chromium.org,ahaas@chromium.org
BUG=

Committed: https://crrev.com/73a988a0d5b24231127eee9019296040e0cefd80
Cr-Commit-Position: refs/heads/master@{#36103}
==========

[commit-bot: I haz the power, 2016-05-09 10:36:31]

Patchset 2 (id:??) landed as
https://crrev.com/73a988a0d5b24231127eee9019296040e0cefd80
Cr-Commit-Position: refs/heads/master@{#36103}