[debugger] refactor debug-scopes.

[debugger] refactor debug-scopes.

R=jgruber@chromium.org

Committed: https://crrev.com/41deb5a2cf7edcf2dd885a6875bae26d8408834d
Cr-Commit-Position: refs/heads/master@{#36108}

[jgruber1, 2016-05-09 09:17:10]

jgruber@google.com changed reviewers:
+ jgruber@google.com

[jgruber1, 2016-05-09 09:17:11]

lgtm

https://codereview.chromium.org/1961833002/diff/1/src/debug/debug-scopes.cc
File src/debug/debug-scopes.cc (right):

https://codereview.chromium.org/1961833002/diff/1/src/debug/debug-scopes.cc#n...
src/debug/debug-scopes.cc:609: 
Nit: Here and below, two lines between functions.

https://codereview.chromium.org/1961833002/diff/1/src/debug/debug-scopes.cc#n...
src/debug/debug-scopes.cc:661: if (!ext.is_null()) {
Nit: Possibly context->has_extension() for readability?

[Yang, 2016-05-09 12:58:28]

https://codereview.chromium.org/1961833002/diff/1/src/debug/debug-scopes.cc
File src/debug/debug-scopes.cc (right):

https://codereview.chromium.org/1961833002/diff/1/src/debug/debug-scopes.cc#n...
src/debug/debug-scopes.cc:609: 
On 2016/05/09 09:17:10, jgruber wrote:
> Nit: Here and below, two lines between functions.

Actually the new guideline is to have only one line between functions, and
clang-format enforces that for new code.

[Yang, 2016-05-09 12:58:32]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-05-09 12:58:32]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@google.com
Link to the patchset: https://codereview.chromium.org/1961833002/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-05-09 12:58:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961833002/20001

[commit-bot: I haz the power, 2016-05-09 13:27:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-09 13:29:00]

Description was changed from

==========
[debugger] refactor debug-scopes.

R=jgruber@chromium.org
==========

to

==========
[debugger] refactor debug-scopes.

R=jgruber@chromium.org

Committed: https://crrev.com/41deb5a2cf7edcf2dd885a6875bae26d8408834d
Cr-Commit-Position: refs/heads/master@{#36108}
==========

[commit-bot: I haz the power, 2016-05-09 13:29:01]

Patchset 2 (id:??) landed as
https://crrev.com/41deb5a2cf7edcf2dd885a6875bae26d8408834d
Cr-Commit-Position: refs/heads/master@{#36108}